Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: ssh: Clean up misplaced AWS-related bits #389

Merged
merged 1 commit into from Mar 7, 2019

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Mar 7, 2019

These are presumably pastos from when the ssh resource was created.

These are presumably pastos from when the ssh resource was created.
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #389 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   89.63%   89.65%   +0.01%     
==========================================
  Files         139      139              
  Lines       10349    10349              
==========================================
+ Hits         9276     9278       +2     
+ Misses       1073     1071       -2
Impacted Files Coverage Δ
reproman/resource/ssh.py 85.71% <100%> (+0.89%) ⬆️
reproman/tests/test_installed.py 85% <0%> (-5%) ⬇️
reproman/utils.py 85.73% <0%> (+0.17%) ⬆️
reproman/config.py 89.61% <0%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dc43f...367fefd. Read the comment docs.

Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like the copy-paste method of coding did not get completely updated for SSH

Will merge

@mjtravers mjtravers merged commit fd7e202 into ReproNim:master Mar 7, 2019
@kyleam kyleam deleted the doc-ssh-pastos branch March 7, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants