Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list formatting multiline with fancy bullets #1406

Merged
merged 3 commits into from Feb 1, 2020

Conversation

@takashi1kun
Copy link
Contributor

takashi1kun commented Jan 22, 2020

In kinda response to: #1283 because i kinda like the fancy bullets so i propose a alternative solution that solves the problem with the list having issues with p elements and with multi lines but keeping the fancy css bullets.

Tested on Chrome, Firefox, Opera and Edge.
image of it working on chrome:
chrome_2020-01-22_14-55-47
and image of it working on firefox:
firefox_2020-01-22_15-11-36

I did not include screenshots of the other because i believe that showing this may be enough, but i can provide it if needed

I have 2 alternative css for the p like

  > p {
        display:inline-table;
      }

or

  > p {
        display:inline-flex;
      }

i just choose to use

  > p {
        display:inline-block;
        vertical-align:top;
        padding-top:0!important;
      }

because i believe that it has more cross browser compatibility, but science for the other fixes i already had to use flex it may not matter.

takashi1kun added 2 commits Jan 22, 2020
In kinda response to: #1283 
Solves the problem with the list having issues with p elements and with multi lines but keeping the fancy css bullets.
Tested on Chrome, Firefox, Opera and Edge.
@auto-assign auto-assign bot requested a review from NGPixel Jan 22, 2020
@takashi1kun

This comment has been minimized.

Copy link
Contributor Author

takashi1kun commented Jan 22, 2020

as a plus this solves the problem caused with link-lists having bullets mentioned here

#1283 (comment)

image

@takashi1kun

This comment has been minimized.

Copy link
Contributor Author

takashi1kun commented Jan 23, 2020

I have to add that only with the code that affects the p element is enough to solve the bug with p elements wrong wrapping.

The code affecting the li and ul solve a bug when you add a multiline with br to a list pressing enter and no p element is generated surronding the code, like

<li>
 "text"
 <br> 
"text"
 </li>
@NGPixel
NGPixel approved these changes Feb 1, 2020
@NGPixel NGPixel merged commit 429c267 into Requarks:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.