Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an override for the ssh port #1432

Merged
merged 2 commits into from Feb 3, 2020
Merged

Conversation

@wallrick
Copy link
Contributor

wallrick commented Feb 3, 2020

Problem:

  • Trying to use git storage feature with a private git server with ssh running on a non-default port. Git over ssh typically happens on port 22 however non-standard setups can use a custom port number. Wiki.js doesn't support adding custom SSH port while setting up the git storage.

Solution:

  • Added an option on the git storage configuration page to allow specifying ssh port. It is optional and empty by default with port 22 used by default if nothing specified.

Testing:

  • Manually validated that the setting is properly picked up.
  • Tested with custom and default ports and everything worked as expected.

Possible future improvement:

  • Adding an advanced ssh section on the git storage page and rolling this configuration into that would be a possible way of simplifying the UI.
@auto-assign auto-assign bot requested a review from NGPixel Feb 3, 2020
@NGPixel
NGPixel approved these changes Feb 3, 2020
@NGPixel NGPixel merged commit b1c7eda into Requarks:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.