From 6a89750a8194d5fc8c546b2999ef57557934b052 Mon Sep 17 00:00:00 2001 From: Ante Date: Mon, 27 Nov 2017 23:37:08 +1100 Subject: [PATCH 1/3] Add tslint for linting --- package.json | 2 ++ tslint.json | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 tslint.json diff --git a/package.json b/package.json index d0401bfd88..4c84b8c9d8 100644 --- a/package.json +++ b/package.json @@ -10,6 +10,7 @@ "scripts": { "clean": "rm -rf ./dist", "build": "npm run clean && tsc && cp -r ./src/artifacts ./dist/src/ && cp ./src/*.json ./dist/src/ && cp -r ./src/lib ./dist/src/", + "lint": "tslint src/**/*.ts", "test": "npm run build && node ./dist/test/test", "testunit": "npm run build && mocha --timeout 15000 dist/test/unit/*.js ", "testdeploy": "npm run build && node ./dist/test/deploy", @@ -25,6 +26,7 @@ "dirty-chai": "^2.0.1", "mocha": "^4.0.1", "ts-node": "^3.3.0", + "tslint": "^5.8.0", "typings": "^2.1.1" }, "dependencies": { diff --git a/tslint.json b/tslint.json new file mode 100644 index 0000000000..7b73ab8410 --- /dev/null +++ b/tslint.json @@ -0,0 +1,9 @@ +{ + "defaultSeverity": "error", + "extends": [ + "tslint:recommended" + ], + "jsRules": {}, + "rules": {}, + "rulesDirectory": [] +} From 76dfefc3d5709943e5ef8ab9669bd32221db6b45 Mon Sep 17 00:00:00 2001 From: Ante Date: Mon, 27 Nov 2017 23:55:03 +1100 Subject: [PATCH 2/3] Adde basic tslint rules that follow existing patterns --- tslint.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tslint.json b/tslint.json index 7b73ab8410..00de593329 100644 --- a/tslint.json +++ b/tslint.json @@ -4,6 +4,10 @@ "tslint:recommended" ], "jsRules": {}, - "rules": {}, + "rules": { + "indent": [true, "spaces", 4], + "quotemark": [true, "single"], + "curly": [true, "ignore-same-line"] + }, "rulesDirectory": [] } From 7a4d44ef95de7d3b7df4ea24765431b0be1de8c0 Mon Sep 17 00:00:00 2001 From: Ante Date: Tue, 28 Nov 2017 00:03:15 +1100 Subject: [PATCH 3/3] Allow leading underscores --- tslint.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tslint.json b/tslint.json index 00de593329..e5230063f7 100644 --- a/tslint.json +++ b/tslint.json @@ -7,7 +7,8 @@ "rules": { "indent": [true, "spaces", 4], "quotemark": [true, "single"], - "curly": [true, "ignore-same-line"] + "curly": [true, "ignore-same-line"], + "variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore"] }, "rulesDirectory": [] }