-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolbar button does not work when status bar is disabled #25
Comments
FF 4.0b8pre here Since this Firefox 4 has the status bar disabled by default, Here, clicking the tool bar button with the status bar disabled does not cause any messages in the error console. |
Replying to [comment:2 rainer]:
Well, of course, there is still the right-click menu, I forgot that (I very rarely use the RP menu there). BTW:
|
This problem is now more urgent with Fx 4, which has a separate "addons bar" instead of a status bar and the addons bar is disabled by default. As a result, people with the toolbar button in use but the status bar enabled will find that RP seems to no longer work after they upgrade to Fx 4. Those users who don't use the toolbar icon and instead will go hunt down how to enable the addons bar in Fx 4 will be fine. |
And, thanks rainer, for drawing attention to this. The big issue here is that making the status bar/toolbar/context menu code all work correctly was initially a giant pain in the XUL. So, if this remains unfixed for a while still, it's because it may turn out to be a big time sink of fiddling and testing with all sorts of Firefox and !SeaMonkey versions. |
Replying to [comment:5 justin]:
As an adddendum to all this if you have the add-on bar enabled in FF4 beta but doing any styling of it (i.e. with CSS via stylish) you end up with a zero height menu: the menu pops up with scroll bars at top and bottom but nothnig else visible. |
This is fixed in r366. This change will be in RP 0.5.17a1. I really thought the fix would be harder because I thought I had tried this solution before. Seems to work in Fx 3.0, 3.6, 4.0b9pre and !SeaMonkey 2.0, 2.1b1. |
If the status bar is not enabled (that is, if one goes to the Firefox "View" menu and disables the status bar), the !RequestPolicy toolbar button does not work. The error that results from clicking on the toolbar button is:
{{{
Error: this._menu.openPopup is not a function
Source file: chrome://requestpolicy/content/overlay.js
Line: 1295
}}}
The text was updated successfully, but these errors were encountered: