ScreenType iPhone Max & XR #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResearchKit/Common/ORKSkin.h
Outdated
| @@ -187,6 +187,7 @@ typedef NS_ENUM(NSInteger, ORKScreenMetric) { | |||
|
|
|||
| typedef NS_ENUM(NSInteger, ORKScreenType) { | |||
| ORKScreenTypeiPhoneX, | |||
| ORKScreenTypeiPhoneMax, | |||
There was a problem hiding this comment.
Suggested change
| ORKScreenTypeiPhoneMax, | |
| ORKScreenTypeiPhoneXSMax, |
There was a problem hiding this comment.
Super-duper minor nit - but can we have the name spelled out a iPhoneXSMax, just to stay consistent with the naming format for all other device screen type names?
There was a problem hiding this comment.
I was thinking of a more general term for future Max models having the same screen resolution, but having e. g. ORKiPhone6ScreenSize as the first model of that size I totally agree to your comment.
srinathtm-apple
approved these changes
Oct 22, 2018
|
Merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds iPhone Max and iPhone XR (same points resolution)