Add review for APPENDIX: RO-Crate JSON-LD #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review for [APPENDIX: RO-Crate JSON-LD](https://www.researchobject.org/ro-crate/1.1-DRAFT/appendix/jsonld.html#handling-relative-uri-references) * "JSON tooling", line 27. Is there any link that can be added here? * "see their individual sections", line 83, is there any link that can be added here? * is the link for this page correct? "(see also notes on [handling relative URI references](#handling-relative-uri-references) below)", line157, refers to a link that happens to be the same link as the one for the whole page
10 tasks
ptsefton
approved these changes
Oct 7, 2020
stain
added a commit
that referenced
this pull request
Oct 22, 2020
1. "JSON tooling" now links to https://www.json.org/ which list lots of libraries 2. Added links to data- and contextual entities pages. 3. Broken `#Link` "handling relative URI references" changed to `relative-uris.md`
|
Thanks @ljgarcia for review! Addressing your points:
|
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review for APPENDIX: RO-Crate JSON-LD