New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alternative] Add collection parameter to search #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be replaced by a viewset soon.
* Update collection filter to handle downstream models * revert NumberInFilter change * revert agian * linting * remove logging
Merged
mcovalt
changed the title
[ALT] Add collection parameter to search
[alternative] Add collection parameter to search
Dec 3, 2021
banesullivan
approved these changes
Dec 7, 2021
banesullivan
added a commit
that referenced
this pull request
Dec 7, 2021
* Remove manual permission path assignment * Remove testing of manual path assignment * Add back mixin to make migrations happy * Remove orphaned REST download function * Remove orphaned REST download function import * Remove unused imports * Implement automatic permissions management * Remove documentation for manual permissions management * Install typing_extensions * [alternative] Add collection parameter to search (#608) * Add `Collection` search filter * Add temporary endpoint for retrieving user's collections This will be replaced by a viewset soon. * Add collection dropdown to search ui * Allow multiple collections to be searched * Add test for collection filter * Fix user collections endpoint * Update for Girder4 stack * Fix error on empty search results * Update collection filter to handle downstream models (#532) * Update collection filter to handle downstream models * revert NumberInFilter change * revert agian * linting * remove logging * Fix endpoint * Simplify filtering * Add back accidentally removed import * Remove testing of orphaned function * Add back accidentally removed queryset * Fix typo in reference to collection filter method * Handle filtering empty collection * Remove breakpoint * Remove testing of orphaned filter by created function * Update authorization logic * Account for collection in factory * Filter distinct results from join Co-authored-by: Mike VanDenburgh <michael.vandenburgh@kitware.com> Co-authored-by: banesullivan <bane.sullivan@kitware.com> Co-authored-by: Mike VanDenburgh <michael.vandenburgh@kitware.com> Co-authored-by: banesullivan <bane.sullivan@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #520
Uses the nifty tools from #607
Much of the work done in #529 was merged in. This ought to be much more performant due to the work in #607.
Note that this changes the authorization logic slightly from #607. See a8bce31. This was included since tests were failing now that
ChecksumFile
has a collection assigned to it in the factory (7a26fcf).