Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alternative] Add collection parameter to search #608

Merged
merged 24 commits into from Dec 7, 2021

Conversation

mcovalt
Copy link
Contributor

@mcovalt mcovalt commented Dec 3, 2021

Alternative solution to #520

Uses the nifty tools from #607

Much of the work done in #529 was merged in. This ought to be much more performant due to the work in #607.

Note that this changes the authorization logic slightly from #607. See a8bce31. This was included since tests were failing now that ChecksumFile has a collection assigned to it in the factory (7a26fcf).

@mcovalt mcovalt mentioned this pull request Dec 3, 2021
@mcovalt mcovalt added the cascaded A large PR that is broken up into smaller ones label Dec 3, 2021
@mcovalt mcovalt changed the title [ALT] Add collection parameter to search [alternative] Add collection parameter to search Dec 3, 2021
@mcovalt mcovalt linked an issue Dec 3, 2021 that may be closed by this pull request
@banesullivan banesullivan merged commit eec3307 into automatic-permissions Dec 7, 2021
@banesullivan banesullivan deleted the collection-filter branch December 7, 2021 02:41
@banesullivan
Copy link
Contributor

Note that this changes the authorization logic slightly from #607. See a8bce31. This was included since tests were failing now that ChecksumFile has a collection assigned to it in the factory (7a26fcf).

I'm going to have to manually test this after merging

banesullivan added a commit that referenced this pull request Dec 7, 2021
* Remove manual permission path assignment

* Remove testing of manual path assignment

* Add back mixin to make migrations happy

* Remove orphaned REST download function

* Remove orphaned REST download function import

* Remove unused imports

* Implement automatic permissions management

* Remove documentation for manual permissions management

* Install typing_extensions

* [alternative] Add collection parameter to search (#608)

* Add `Collection` search filter

* Add temporary endpoint for retrieving user's collections
This will be replaced by a viewset soon.

* Add collection dropdown to search ui

* Allow multiple collections to be searched

* Add test for collection filter

* Fix user collections endpoint

* Update for Girder4 stack

* Fix error on empty search results

* Update collection filter to handle downstream models (#532)

* Update collection filter to handle downstream models

* revert NumberInFilter change

* revert agian

* linting

* remove logging

* Fix endpoint

* Simplify filtering

* Add back accidentally removed import

* Remove testing of orphaned function

* Add back accidentally removed queryset

* Fix typo in reference to collection filter method

* Handle filtering empty collection

* Remove breakpoint

* Remove testing of orphaned filter by created function

* Update authorization logic

* Account for collection in factory

* Filter distinct results from join

Co-authored-by: Mike VanDenburgh <michael.vandenburgh@kitware.com>
Co-authored-by: banesullivan <bane.sullivan@kitware.com>

Co-authored-by: Mike VanDenburgh <michael.vandenburgh@kitware.com>
Co-authored-by: banesullivan <bane.sullivan@kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cascaded A large PR that is broken up into smaller ones priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection facet in search filter
3 participants