diff --git a/CommunityBugFixCollection/Locale/de.json b/CommunityBugFixCollection/Locale/de.json index 1496dad..213d4bc 100644 --- a/CommunityBugFixCollection/Locale/de.json +++ b/CommunityBugFixCollection/Locale/de.json @@ -44,7 +44,7 @@ "CommunityBugFixCollection.TiltedUIAlignment.Description": "Kippt die UI-fokussierte Kamera, um UIX-Renderprobleme zum umgehen.", "CommunityBugFixCollection.StationaryGrabWorldActivation.Description": "Verhindert, dass die Welt-Greifen Fortbewegung den Spieler bei jeder Aktivierung bewegt.", "CommunityBugFixCollection.ValidQuaternionInputs.Description": "Lässt das ProtoFlux-Tool valide float und double Quaternions spawnen.", - "CommunityBugFixCollection.UserInspectorAsNonHost.Description": "Sorgt dafür, dass Benutzer-Inspektoren bereits präsente Benutzer auch in Sessions anzeigen, in denen man nicht der Host ist.", + "CommunityBugFixCollection.ValueModDecimal.Description": "Fügt eine Nullprüfung bei der Decimal ValueMod ProtoFlux Node hinzu, um einen Crash bei der Teilung durch Null zu verhindern.", "CommunityBugFixCollection.Config.Options.Name": "Optionen", "CommunityBugFixCollection.Config.Options.Description": "Enthällt die Einstellungen für die wenigen Fixes die diese anbieten.", diff --git a/CommunityBugFixCollection/Locale/en.json b/CommunityBugFixCollection/Locale/en.json index fe1fbda..5db0211 100644 --- a/CommunityBugFixCollection/Locale/en.json +++ b/CommunityBugFixCollection/Locale/en.json @@ -48,9 +48,8 @@ "CommunityBugFixCollection.SmoothDraggables.Description": "Workaround for Sliders and Joints snapping in sessions hosted by a headless.", "CommunityBugFixCollection.StationaryGrabWorldActivation.Description": "Stops the Grab World Locomotion from moving the player with each activiation.", "CommunityBugFixCollection.TiltedUIAlignment.Description": "Tilts the UI-Focus camera to work around UIX rendering issues.", - "CommunityBugFixCollection.UserInspectorAsNonHost.Description": "Fixes UserInspectors not listing existing users in the session for non-host users.", "CommunityBugFixCollection.ValidQuaternionInputs.Description": "Makes the ProtoFlux Tool spawn valid float and double quaternion inputs.", - "CommunityBugFixCollection.ValueModDecimal.Description": "Adds a zero check to the Decimal ValueMod ProtoFlux node to prevent DIV/0 crashes", + "CommunityBugFixCollection.ValueModDecimal.Description": "Adds a zero check to the Decimal ValueMod ProtoFlux node to prevent DIV/0 crashes.", "CommunityBugFixCollection.Config.Options.Name": "Options", "CommunityBugFixCollection.Config.Options.Description": "Contains the settings for the few fixes that offer them.", diff --git a/CommunityBugFixCollection/UserInspectorsAsNonHost.cs b/CommunityBugFixCollection/UserInspectorsAsNonHost.cs deleted file mode 100644 index c4f3018..0000000 --- a/CommunityBugFixCollection/UserInspectorsAsNonHost.cs +++ /dev/null @@ -1,41 +0,0 @@ -using FrooxEngine; -using FrooxEngine.UIX; -using HarmonyLib; -using MonkeyLoader.Resonite; -using System; -using System.Collections.Generic; -using System.Text; - -namespace CommunityBugFixCollection -{ - [HarmonyPatch(typeof(UserInspector), nameof(UserInspector.OnAttach))] - [HarmonyPatchCategory(nameof(UserInspectorAsNonHost))] - internal class UserInspectorAsNonHost : ResoniteMonkey - { - public override IEnumerable Authors => Contributors.Nytra; - - public override bool CanBeDisabled => true; - - private static void Postfix(UserInspector __instance) - { - if (!Enabled || __instance.World.IsAuthority) - return; - - // Wait a bit to see if anything gets generated by the host - __instance.RunInSeconds(2, () => - { - // Check if any items were generated, just in case this gets fixed in the future - if (__instance._userListContentRoot.Target.ChildrenCount != 0) - return; - - foreach (var user in __instance.World.AllUsers) - { - var slot = __instance._userListContentRoot.Target.AddSlot("User"); - slot.PersistentSelf = false; - slot.AttachComponent().PaddingTop.Value = 4f; - slot.AttachComponent().Setup(user); - } - }); - } - } -} \ No newline at end of file diff --git a/README.md b/README.md index a6bc808..858ce7d 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,6 @@ just disable them in the settings in the meantime. * https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/1157 * https://github.com/Yellow-Dog-Man/Locale/issues/186 * ColorX From HexCode (ProtoFlux node) defaults to Linear profile (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/1404) -* UserInspectors not listing existing users in the session for non-host users (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/1964) * ProtoFlux value casts from byte to other values converting incorrectly (mono / graphical client only) (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/2257) * `ValueMod` node crashes the game when B input is set to zero or disconnected. (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/2746) * Grid World grid being off-center (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/2754) @@ -96,4 +95,5 @@ If they appear here, their implementation has been removed from the mod. * Duplicating Components breaking drives (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/92) * Pressing Duplicate on the Component in an Inspector - * Using the Component Clone Tool to duplicate them onto a slot \ No newline at end of file + * Using the Component Clone Tool to duplicate them onto a slot +* UserInspectors not listing existing users in the session for non-host users (https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/1964) \ No newline at end of file