Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid renders slightly differently on Safari #40

Closed
cvrebert opened this issue Aug 8, 2014 · 2 comments
Closed

Grid renders slightly differently on Safari #40

cvrebert opened this issue Aug 8, 2014 · 2 comments
Labels
css

Comments

@cvrebert
Copy link
Contributor

@cvrebert cvrebert commented Aug 8, 2014

Example: http://jsfiddle.net/wyrefkmg/4/

OS X Chrome (which is nearly identical to OS X Firefox):
chrome

Safari v7.0.5 on OS X 10.9.4:
safari

Note how the 6 and the 7 aren't aligned, and how there's extra blue padding on the right edge of the first row.

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Aug 8, 2014

Yeah... Safari's rounding errors are a nightmare and is a browser bug rather than a framework one as it would affect any percentile based grid system

There's not really a huge amount that can be done at present; the grid calculations are correct. Adding push or push-{grid range} to the last column would even things out a little but it's a bit hacky for my liking.

I should document it though to make sure people are aware of the issue. Fingers crossed Apple will do a better job with upcoming releases.

@cvrebert
Copy link
Contributor Author

@cvrebert cvrebert commented Aug 13, 2014

Fixed by c123be3

@cvrebert cvrebert closed this Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.