Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban functions in sizes other than calc() #241

Closed
zcorpan opened this issue Sep 9, 2014 · 1 comment
Closed

Ban functions in sizes other than calc() #241

zcorpan opened this issue Sep 9, 2014 · 1 comment

Comments

@zcorpan
Copy link

@zcorpan zcorpan commented Sep 9, 2014

It's not super clear what toggle() and attr() should do in sizes="". We should just ban anything but calc().

@tabatkins
Copy link

@tabatkins tabatkins commented Sep 9, 2014

toggle() technically works, but since there's no inherited value, it'll just always select its first value. Fine to ban it.

attr() is technically only defined within the context of a property, which sizes isn't, so it doesn't actually work. Fine to ban it too.

I agree that it should be fine to just whitelist calc(), and we can expand the list in the future if needed.

@zcorpan zcorpan closed this in 2e3de79 Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.