New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onerror when environment changed? #249

Closed
yoavweiss opened this Issue Oct 17, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@yoavweiss
Member

yoavweiss commented Oct 17, 2014

As part of a commit to avoid onerror firing when an environment change triggered and image load, @mikewest and myself started discussing whether or not it is the right thing to do. Discussion continued on IRC as well.

@zcorpan - was I correct in my estimate regarding the rational there? Is it to avoid different browsers firing onerror differently?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Oct 27, 2014

The image doesn't change to the broken state, so firing an error event seems slightly off. You can log to the console that the load failed. Is there a use case for notifying JS?

zcorpan commented Oct 27, 2014

The image doesn't change to the broken state, so firing an error event seems slightly off. You can log to the console that the load failed. Is there a use case for notifying JS?

@yoavweiss

This comment has been minimized.

Show comment
Hide comment
@yoavweiss

yoavweiss Nov 5, 2014

Member

/me is back from some quality time with the mother-in-law

@mikewest - are you OK with @zcorpan's explanation? Would you like me to add console errors to https://codereview.chromium.org/654253003/ instead of the unfired onerror?

Member

yoavweiss commented Nov 5, 2014

/me is back from some quality time with the mother-in-law

@mikewest - are you OK with @zcorpan's explanation? Would you like me to add console errors to https://codereview.chromium.org/654253003/ instead of the unfired onerror?

@mikewest

This comment has been minimized.

Show comment
Hide comment
@mikewest

mikewest Nov 6, 2014

Yeah, I trust you to make the right decision here. I just want to ensure it's been considered.

mikewest commented Nov 6, 2014

Yeah, I trust you to make the right decision here. I just want to ensure it's been considered.

@yoavweiss

This comment has been minimized.

Show comment
Hide comment
@yoavweiss

yoavweiss Nov 6, 2014

Member

Cool. Closing then

Member

yoavweiss commented Nov 6, 2014

Cool. Closing then

@yoavweiss yoavweiss closed this Nov 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment