New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline updates #232

Merged
merged 1 commit into from Jul 22, 2014

Conversation

Projects
None yet
3 participants
@zcorpan
Copy link

zcorpan commented Jul 21, 2014

@Hixie asked me to apply this change. Should be editorial.

Pipeline updates
@Hixie asked me to apply this change. Should be editorial.
@@ -503,7 +503,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</pre>

<li><p>A <code data-x="attr-picture-source-media">media</code> attribute specified with a value that,
after <span data-x="strip leading and trailing whitespace">stripping leading and trailing whitespace</span>,
is not the empty string and is not an <span>ASCII case-insensitive</span> match for the string <code>all</code>.</p></li>
is not the empty string and is not an <span>ASCII case-insensitive</span> match for the string "<code data-x="">all</code>".</p></li>

This comment has been minimized.

@tabatkins

tabatkins Jul 21, 2014

Is it intentional that this appears to be the sole diff line that is adding a data-x="" attribute?

This comment has been minimized.

@Hixie

Hixie Jul 21, 2014

Long-term, the keyword "all" should just be defined as a term and cross-referenced. The data-x="" here is just making sure that it doesn't end up cross-referencing to something else later if there's ever a all added.

tabatkins added a commit that referenced this pull request Jul 22, 2014

@tabatkins tabatkins merged commit 2f7e23c into gh-pages Jul 22, 2014

@zcorpan zcorpan deleted the hixie-new-pipeline branch Aug 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment