New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #234 - Clarify that percentage-based values are invalid in `sizes` #235

Closed
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
3 participants
@Wilto
Member

Wilto commented Aug 1, 2014

image

<p class="note">
While this syntax is largely based on the now-defunct <code>srcn</code> proposal for responsive images,
<code>sizes</code> differs in that percentage-based values are not allowed.

This comment has been minimized.

@yoavweiss

yoavweiss Aug 1, 2014

Member

Maybe add an "in order to avoid confusion as to which length the percentage relates to" (or something better)?

@yoavweiss

yoavweiss Aug 1, 2014

Member

Maybe add an "in order to avoid confusion as to which length the percentage relates to" (or something better)?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Aug 2, 2014

Please don't fix things in the index.* files.

zcorpan commented Aug 2, 2014

Please don't fix things in the index.* files.

@zcorpan zcorpan closed this Aug 2, 2014

@zcorpan zcorpan deleted the issue-234 branch Aug 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment