New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref. #220 - Fixes missing `alt` attribute. #236

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
2 participants
@Wilto
Member

Wilto commented Aug 1, 2014

Original issue references something outside the repo, but found a couple of minor related issues in the spec.

@yoavweiss

This comment has been minimized.

Show comment
Hide comment
@yoavweiss

yoavweiss Aug 1, 2014

Member

LGTM

Member

yoavweiss commented Aug 1, 2014

LGTM

yoavweiss added a commit that referenced this pull request Aug 1, 2014

Merge pull request #236 from ResponsiveImagesCG/issue-220
Ref. #220 - Fixes missing `alt` attribute.

@yoavweiss yoavweiss merged commit 267cf8e into gh-pages Aug 1, 2014

@yoavweiss yoavweiss deleted the issue-220 branch Aug 1, 2014

@yoavweiss

This comment has been minimized.

Show comment
Hide comment
@yoavweiss

yoavweiss Aug 2, 2014

Member

I reverted this since as @zcorpan commented, we shouldn't be fixing the old spec, but the WHATWG integrated one.

Member

yoavweiss commented Aug 2, 2014

I reverted this since as @zcorpan commented, we shouldn't be fixing the old spec, but the WHATWG integrated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment