New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display role information in AdminUI #1103

Closed
otsakir opened this Issue May 23, 2016 · 11 comments

Comments

Projects
None yet
3 participants
@otsakir
Contributor

otsakir commented May 23, 2016

One can't tell what role an account is assigned to. Should we add this piece of information in the form ?

@otsakir otsakir self-assigned this May 23, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented May 23, 2016

Yes

@otsakir

This comment has been minimized.

Contributor

otsakir commented May 23, 2016

depends on #1105

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented May 24, 2016

@otsakir @deruelle i don't know whether anyone is working on this issue or not i add role value in Account response and shows it on AdminUI .My branch location is
https://github.com/muhammadbilal19/Restcomm-Connect/tree/Issue-1105

if you want i can give it to you for review.

Sorry I didn't ask before fixing i just see and implement it :)

@deruelle deruelle assigned muhammadbilal19 and unassigned otsakir May 24, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented May 24, 2016

@muhammadbilal19 do you want to do a pull request on this so that @otsakir can review ?

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented May 24, 2016

Pull request created for this change.
#1109

@deruelle

This comment has been minimized.

Member

deruelle commented May 24, 2016

great @otsakir can you review ?

@deruelle deruelle added this to the 7.7.0 milestone May 24, 2016

@otsakir

This comment has been minimized.

Contributor

otsakir commented May 24, 2016

Thanks for the contribution @muhammadbilal19. I'll review your PR and get back to you.

@otsakir

This comment has been minimized.

Contributor

otsakir commented May 25, 2016

@muhammadbilal19, your patch has been merged.

@otsakir otsakir closed this May 25, 2016

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented May 25, 2016

Thanks @otsakir for confirming. I just see that i miss the xml response part which you fix thanks for that.

@otsakir

This comment has been minimized.

Contributor

otsakir commented May 26, 2016

np @muhammadbilal19. email_address field was also wrong so it seems that you were unlucky enough to pick the wrong reference :-).

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented May 26, 2016

:) yup anyways one extra issue is resolved along with this so it is good that i choose that one as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment