New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache-uri is wrong for external media server options #1124

Closed
hamsterksu opened this Issue May 30, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@hamsterksu
Contributor

hamsterksu commented May 30, 2016

Hi

i have found a bug: cache-uri doesn't contains restcomm port
in case if external mediaserver is specified

-e "s|<cache-uri>.*</cache-uri>|<cache-uri>https://$REMOTEADD/restcomm/cache</cache-uri>|" \

https://github.com/RestComm/Restcomm-Connect/blob/master/restcomm/configuration/config-scripts/as7-config-scripts/restcomm/autoconfig.d/config-restcomm.sh#L436

thanks,

@hamsterksu

This comment has been minimized.

Contributor

hamsterksu commented May 30, 2016

@deruelle, @leftyb, @hrosa it's very important for our customer. is it possible to get it today?

@deruelle

This comment has been minimized.

Member

deruelle commented May 30, 2016

@hamsterksu can you do a pull request for this ? this will help speed up the process.

@deruelle deruelle added the 1. Bug label May 30, 2016

@deruelle deruelle modified the milestones: 7.7.0, 8.0.0 May 30, 2016

@hamsterksu

This comment has been minimized.

Contributor

hamsterksu commented May 30, 2016

@deruelle i have added PR

@otsakir otsakir added the Peer Review label May 30, 2016

@leftyb

This comment has been minimized.

Contributor

leftyb commented May 31, 2016

@hamsterksu ,

Thank you for your contribution.
There is a small issue at your PR. You use "http" always. Need to use either "http" or "https".
For that reason you can see the "if [ "$DISABLE_HTTP" = "true" ]; then"
You can add a transport variable as well, if you want.

Regards

@gvagenas gvagenas modified the milestones: 8.0.0, 7.8.0 May 31, 2016

@hamsterksu

This comment has been minimized.

Contributor

hamsterksu commented May 31, 2016

@leftyb thank you for review.
i have fixed it.

@leftyb leftyb closed this in f6058dd Jun 6, 2016

leftyb added a commit that referenced this issue Jun 6, 2016

@leftyb leftyb removed the Peer Review label Jun 6, 2016

maria-farooq pushed a commit to maria-farooq/Restcomm-Connect that referenced this issue Jun 6, 2016

Maria Farooq
Merge branch 'master' of https://github.com/Restcomm/Restcomm-Connect
…into issue-5

# By Thinh Ly (6) and others
# Via George Vagenas (6) and others
* 'master' of https://github.com/Restcomm/Restcomm-Connect:
  fix RestComm#1124
  Regression fix for Account menu scrollbar in AdminUI.
  Check for getRawContent. This close RestComm#1150
  Fix for DB upgrade script
  Fixed broken Client creation in AdminUI.
  Fixing broken links
  Surround create Cancel method and provide logging to check for NPE. This refers to RestComm#1128
  Feature flag to disable SDP patching on updatingMediaSession. This close RestComm#1138
  Fixes for WebTrigger. - Refactored web trigger authentication. - Properly handle inactive accounts too.
  Fix RvdController /log method. - Patched RvdController to properly handle RVD context.
  Fixes for issue RestComm#784
  Proper testing for issue RestComm#784
  This resolve RestComm#784 - remove the forgotten printout
  This resolves RestComm#784
  Fix for issue RestComm#784
  This resolves RestComm#784
  This resolves RestComm#784
  Fix for issue RestComm#784
  This resolves RestComm#784
  This resolves RestComm#784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment