New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging Capabilities for IncomingPhoneNumbers API #2189

Closed
deruelle opened this Issue Jun 5, 2017 · 17 comments

Comments

@deruelle
Member

deruelle commented Jun 5, 2017

Need to implement Paging at API level and Dashboard level as well

@jaimecasero

This comment has been minimized.

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 7, 2017

@deruelle @gvagenas Is anyone is working on that issue currently? because i am bit confuse as this issue has Help Wanted Label and assigned to some members as well. If it is still available i wanted to contribute for this issue.
I was just looking for some of other API's and just found that only Logs tab (Calls, Messages, Recordings, Transcriptions, Notifications and Conference) has paging functionality on API level as far i know.

@deruelle

This comment has been minimized.

Member

deruelle commented Jun 7, 2017

@muhammadbilal19 we just created the issue yesterday so no one has had time to work on it yet. By all means, if you can take it on. It would make sense to actually create an issue per API not having paging functionality and do a PR per issue. What would be your estimate to complete this first issue ?

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 7, 2017

Great @deruelle i will start looking into that issue and will share the estimate with you soon.

@deruelle

This comment has been minimized.

Member

deruelle commented Jun 7, 2017

Awesome. Thanks @muhammadbilal19 looking forward to it

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Jun 7, 2017

Hi @muhammadbilal19,

Thanks for your interest.
We have a weekly public meeting on Wednesday 3pm UTC here https://gitter.im/RestComm/Restcomm-discuss.
If this time suits you, you can join and synch with team on progress of this task and other projects that team is working on.
Looking forward to seeing you there.

Thanks
Maria

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Jun 8, 2017

Hi @muhammadbilal19 The urgency on this particular issue has gone up due to a customer with a huge quantity of phone numbers to manage.

If you don't have the time to get to this right away and provide a firm estimate we need to assign it to an internal resource.

If you could let me know by June 9 what you think that would be great.

We have several other APIs with the same issue that are lower priority that we'd love for you to take over if you don't have immediate time for this one.

Thanks for contributing!

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 8, 2017

Hi @scottbarstow yesterday i started working on it and completed the API part this issue. Now i am playing with UI to show pagination on this module. Once i done with this changes and testing then i will create PR.

I pretty much hopeful to complete this issue by 10 June.

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Jun 8, 2017

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Jun 8, 2017

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Jun 8, 2017

@muhammadbilal19 let's plan to do two PRs, one for the API changes and one for the UI changes so that we can have them reviewed internally in parallel.

Does that work for you?

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 8, 2017

@scottbarstow sounds like a good plan i will finalise the API code and will create separate PR for API.Will try to fix sorting as well :)

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 8, 2017

RestComm#2189
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 9, 2017

Add sorting by friendly_name and phone_number
Change pagination footer like 1 to 10 of 1000
RestComm#2189
@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 9, 2017

@scottbarstow i created PR with API and UI changes #2211, I am managed to finish both the changes :)

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 9, 2017

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017

RestComm#2189
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017

Add sorting by friendly_name and phone_number
Change pagination footer like 1 to 10 of 1000
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Adding test cases for pagination functionality of IncomingPhone
Add RestComm tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Revert "Adding test cases for pagination functionality of IncomingPho…
…ne Add RestComm tools class to remove some repeating code. Replace System.out to logger.info IncomingPhoneNumbersEndpointTest RestComm#2189"

This reverts commit ccf03b6.

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Adding test cases for pagination functionality of IncomingPhone
Add RestCommIncomingPhone tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

RestComm#2189
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Add sorting by friendly_name and phone_number
Change pagination footer like 1 to 10 of 1000
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Adding test cases for pagination functionality of IncomingPhone
Add RestComm tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Revert "Adding test cases for pagination functionality of IncomingPho…
…ne Add RestComm tools class to remove some repeating code. Replace System.out to logger.info IncomingPhoneNumbersEndpointTest RestComm#2189"

This reverts commit ccf03b6.

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

Adding test cases for pagination functionality of IncomingPhone
Add RestCommIncomingPhone tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 14, 2017

@gvagenas gvagenas closed this in f79e0e7 Jun 15, 2017

gvagenas added a commit that referenced this issue Jun 15, 2017

gvagenas added a commit that referenced this issue Jun 15, 2017

gvagenas added a commit that referenced this issue Jun 15, 2017

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 15, 2017

Merge last commited changes for RestComm#2189
Implement sorting with db query and start and end value fix RestComm#2189
@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Jun 21, 2017

@muhammadbilal19 this got deployed to our production instance today. Great work and thanks for taking care of all of this. Major uplift

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 21, 2017

Thanks @scottbarstow for the update hopefully it will improve user experience. Hopefully soon we are able to deploy clients and account pagination as well.

@deruelle

This comment has been minimized.

Member

deruelle commented Jun 22, 2017

Closing this issue. @muhammadbilal19 congrats and you have been acknowledged at https://telestax.com/acknowledgements/

@deruelle deruelle reopened this Jun 22, 2017

@deruelle deruelle closed this Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment