New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement default beep when user leaves a conference room #78

Closed
ivelin opened this Issue Oct 14, 2014 · 13 comments

Comments

Projects
None yet
5 participants
@ivelin
Contributor

ivelin commented Oct 14, 2014

Currently there is a default beep when a new user joins a conference room, but no indication when a user leaves the conference.

@ivelin ivelin added this to the 7.2.1 milestone Oct 14, 2014

@ivelin ivelin modified the milestones: 7.2.1, 7.3.0 Jan 16, 2015

@ivelin

This comment has been minimized.

Contributor

ivelin commented Feb 2, 2015

@croufay update on this issue?

@desipepova desipepova modified the milestones: 7.2.2, 7.3.0 Feb 8, 2015

@gvagenas gvagenas modified the milestones: 7.3.1, 7.2.2 May 25, 2015

@gvagenas gvagenas modified the milestones: 7.4.0, 7.3.1 Aug 26, 2015

@gvagenas gvagenas modified the milestones: 7.4.0, 7.5.0 Oct 30, 2015

@deruelle deruelle assigned gvagenas and unassigned croufay Nov 27, 2015

@gvagenas gvagenas added the Help Wanted label Jan 7, 2016

@gvagenas gvagenas modified the milestones: 7.6.0, 7.5.0 Jan 7, 2016

@deruelle deruelle assigned maria-farooq and unassigned gvagenas Feb 12, 2016

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 16, 2016

Hi Team, So far I made conference call and produce the problem statement, using 3 participants (linphone, jitni and x-lite) I have also read code and I believe the changes are in
org.mobicents.servlet.restcomm.interpreter.VoiceInterpreter

Now i will make my changes in a feature branch and will test them by building on my local machine.

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Feb 16, 2016

Hi @maria-farooq thanks for your work here and your updates.

Just a comment here to help you on the testing.

To avoid the long time it takes to build the Restcomm binary, a quick way for testing is the following:

  1. Download latest Restcomm and delete the existing Restcomm jars rm -rf $RESTCOMM_HOME/standalone/deployements/restcomm.war/WEB-INF/lib/restcomm*
  2. Build Restcomm jars. Go to the main folder of the project (source code) and run mvn clean install -Dmaven.test.skip
  3. Copy all new jar files to the binary: cp -ar $RESTCOMM_SOURCE/restcomm/restcomm.application/target/restcomm/WEB-INF/lib/* $RESTCOMM_HOME/standalone/deployments/restcomm.war/WEB-INF/lib/

This way you can quickly test your patch. When you are done with the patch, make sure you run the Restcomm testsuite and make sure that nothing is broken.

Hope it helps.
George

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 16, 2016

Its indeed a great piece of help @gvagenas, Thanks.
As directed by openSourcePlaybook i created fork of RestComm-Core https://github.com/maria-farooq/RestComm-Core/, I have not came across any conventions about naming git branches, so i will go for "issue-78".
Thanks again for help it will speed up my testing process.
Maria

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Feb 16, 2016

@maria-farooq there is no naming convention for branches indeed, "issue-78" will work.

Thanks

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 16, 2016

Hi Team,
I am able to play beep on exit of any participant. here is my code change https://github.com/maria-farooq/RestComm-Core/commit/1732926c50fff94212c0d9e71906e0eaaebce67d i build and tested it on my machine. I have also checked that "play beep code" does not execute on exit of last participant as there is no one left to listen to the beep.

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Feb 16, 2016

Hi @maria-farooq great job! Please create a pul request from your branch and I will review your work as soon as possible.

Thanks
George

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 17, 2016

Hi @gvagenas, pull request is created. https://github.com/RestComm/RestComm-Core/pull/875/files

Thanks
Maria

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Feb 17, 2016

@maria-farooq thanks, I will review that

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 20, 2016

Hi @gvagenas i saw your comment on pull request and this new requirement makes sense, let me do some study and changes accordingly and i will update you.
Thanks for your review and encouragement,
Maria.

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 22, 2016

Hi @gvagenas i have tested and commited changes, i have made audio files configureable in restcomm.xml.
If not found in config, by default entry=beep.wav, exit=alert.wav will be played on entry and exit respectively.
I noticed a docbook chapter also contained guide about restcomm.xml so i updated that as well.
Please review,

Thanks,
Maria

@maria-farooq

This comment has been minimized.

Collaborator

maria-farooq commented Feb 23, 2016

@gvagenas i don't see edit button with this issue (looks like i don't have some permissions), so i am unable to close this issue.
I just noticed that if i have had added 'close' or 'fix' keywords in my commit message it would have automatically closed with the merge of pull request.
Its a bit late for that :)
so i need your help to close it.

Thanks
Maria

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Feb 23, 2016

I will close it, thanks @maria-farooq

@gvagenas gvagenas closed this Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment