New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add a scroll bar at the sub accounts list. #856

Closed
leftyb opened this Issue Feb 8, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@leftyb
Contributor

leftyb commented Feb 8, 2016

When the the registered users are more than a certain number, not possible to see the last users in the list. Need to zoom out to be able to see them all.
sub_accounts

@deruelle deruelle added the Help Wanted label Feb 8, 2016

@deruelle deruelle added this to the 7.6.0 milestone Feb 8, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Feb 8, 2016

Since the number of sub accounts can go to 1000. I think a More... link to the dedicated page with paging and searching would be more effective than an scroll bar. Added Help Wanted tag for contributors here.

@gvagenas gvagenas modified the milestones: 7.6.0, 7.7.0 Apr 27, 2016

@gvagenas gvagenas modified the milestone: 7.7.0 May 13, 2016

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 11, 2016

@leftyb @deruelle
I created a table of subaccounts with pagination and filters. Please have a look and let me know if you want to add anythings else in it.If you guys are ok with design i will commit my code.

restcomm

subaccounts

subaccountsfilters

@deruelle deruelle added this to the 7.8.0 milestone Jun 13, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Jun 13, 2016

@muhammadbilal19 great ! did you do a PR of that ?

@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 13, 2016

@deruelle sure i will create a PR for that fix today.

muhammadbilal19 pushed a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 14, 2016

Muhammad Bilal
Fix issue RestComm#856 by adding grid for subaccounts with pagination…
… and

filter, remove the subaccounts list from menu and add new menu link fot
subaccounts grid page.
@muhammadbilal19

This comment has been minimized.

Collaborator

muhammadbilal19 commented Jun 14, 2016

@deruelle PR created for this issue.

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 17, 2016

Fix issue RestComm#856 by adding grid for subaccounts with pagination…
… and

filter, remove the subaccounts list from menu and add new menu link fot
subaccounts grid page.

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 17, 2016

refresh the sub accounts table without reload of the page in case new
account created
Show total number of sub account without the parent account (list-1)
RestComm#856

@otsakir otsakir modified the milestones: 7.9.0, 7.8.0 Jul 1, 2016

otsakir added a commit that referenced this issue Aug 2, 2016

Merge branch 'issue-856' of https://github.com/muhammadbilal19/Restco…
…mm-Connect into muhammadbilal19-issue-856.

Conflicts:
        restcomm/restcomm.ui/src/main/webapp/resources/js/controllers/navbar.js
        restcomm/restcomm.ui/src/main/webapp/templates/navbar.html

Also:
- Filtered received accounts so that parent is removed from the list.
  This fixes buggy behaviour in some cases.
- Fixed filtering in logs/notifications when re-clearing the filter values. Refers #1309.

Refers #856, #1309

@otsakir otsakir closed this Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment