New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy-Authentication does not work if uri has uri-parameters #935

Closed
thaeger71 opened this Issue Mar 17, 2016 · 13 comments

Comments

Projects
None yet
3 participants
@thaeger71
Collaborator

thaeger71 commented Mar 17, 2016

If a client sends a REGISTER with parameters in request uri, for example:

test@192.168.1.1;transport=udp

Then this request uri will be included as uri field in the digest which comes from client, and then the authentication does not work on RestComm. It sends just 407 again and again ....

Tested with snom phone, just enter as registrar 192.168.1.1:5080;transport=tcp
The phone then try to register via tcp, and then you can watch this behaviour.
If you discharge this parameter, the phone will again try to register via udp and oh wonder, it works.

Btw, in case that authentication failed there a better messages for sure just as send another 407 which ends in an endless loop....

@thaeger71 thaeger71 changed the title from Proxy-Athentication does not work if uri has uri-parameters to Proxy-Authentication does not work if uri has uri-parameters Mar 17, 2016

@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 17, 2016

Sorry I forgot to mention the version I'am using:

RestComm v7.6.0-SNAPSHOT

@deruelle deruelle added the 1. Bug label Mar 17, 2016

@deruelle deruelle added this to the 7.7.0 milestone Mar 17, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Mar 17, 2016

Thanks @thaeger71 for opening the issue. Would you like to try contributing a patch for it ?

@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 18, 2016

Hello Jean,

yes, I would like to try to contribute a patch.
I've already identified the issue, and I will try to provide a patch soon.

Greets,

Thomas.

2016-03-17 18:18 GMT+01:00 Jean Deruelle notifications@github.com:

Thanks @thaeger71 https://github.com/thaeger71 for opening the issue.
Would you like to try contributing a patch for it ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#935 (comment)


Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de


@deruelle

This comment has been minimized.

Member

deruelle commented Mar 18, 2016

@thaeger71 Great ! Thanks !

You can follow the Dev Process section of our open source playbook for contributions

@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 18, 2016

Hello Jean,

I really appriciate the openness with you invited me to contribute to this
repository, but I don't want to make something wrong.
Therefore I would like to ask you to apply my attached patch for several
fixes:

fixes for Issue #935: bug with uri-parameters in Digest, changed answer to
unsuccessful REGISTER to 403 FORBIDDEN, disabled keepalive (OPTIONS) even
for tcp sessions

Greets,

Thomas.

2016-03-18 9:34 GMT+01:00 Jean Deruelle notifications@github.com:

Assigned #935 #935
to @thaeger71 https://github.com/thaeger71.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#935 (comment)


Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de


@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 18, 2016

Hi Jean,

I just want to ask you to wait with applying the patch...I found a similar
issue with the callhandler (CallControlHelper) .....

Thnx,
Thomas.

2016-03-18 13:44 GMT+01:00 Thomas Häger thaeger@hdsnetz.de:

Hello Jean,

I really appriciate the openness with you invited me to contribute to this
repository, but I don't want to make something wrong.
Therefore I would like to ask you to apply my attached patch for several
fixes:

fixes for Issue #935: bug with uri-parameters in Digest, changed answer to
unsuccessful REGISTER to 403 FORBIDDEN, disabled keepalive (OPTIONS) even
for tcp sessions

Greets,

Thomas.

2016-03-18 9:34 GMT+01:00 Jean Deruelle notifications@github.com:

Assigned #935 #935
to @thaeger71 https://github.com/thaeger71.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#935 (comment)


Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de



Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de


@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 18, 2016

fyi: new patch attached

2016-03-18 14:44 GMT+01:00 Thomas Häger thaeger@hdsnetz.de:

Hi Jean,

I just want to ask you to wait with applying the patch...I found a similar
issue with the callhandler (CallControlHelper) .....

Thnx,
Thomas.

2016-03-18 13:44 GMT+01:00 Thomas Häger thaeger@hdsnetz.de:

Hello Jean,

I really appriciate the openness with you invited me to contribute to
this repository, but I don't want to make something wrong.
Therefore I would like to ask you to apply my attached patch for several
fixes:

fixes for Issue #935: bug with uri-parameters in Digest, changed answer
to unsuccessful REGISTER to 403 FORBIDDEN, disabled keepalive (OPTIONS)
even for tcp sessions

Greets,

Thomas.

2016-03-18 9:34 GMT+01:00 Jean Deruelle notifications@github.com:

Assigned #935 #935
to @thaeger71 https://github.com/thaeger71.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#935 (comment)


Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de



Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de



Dipl.- Ing. Thomas Häger
Wiesbadener Str. 4
12161 Berlin
Tel.: +49 30 854 016 46
Mobile: +49 176 24250798
mailto:thaeger@hdsnetz.de


@deruelle

This comment has been minimized.

Member

deruelle commented Mar 21, 2016

@thaeger71 we don't accept patches as files but as Pull Request only (https://github.com/RestComm/Restcomm-Connect/pulls).

You need to follow the Pull Request section of our open source playbook

@deruelle

This comment has been minimized.

Member

deruelle commented Mar 29, 2016

@thaeger71 just checking if there is anything blocking from your side in doing a formal github pull request for that issue ?

@thaeger71

This comment has been minimized.

Collaborator

thaeger71 commented Mar 29, 2016

Hello Jean,

nothing blocking, except work. I just was in vacation, today first day I'am back...and I have a lot of other things at the moment to do, so I will see when I'am able to do the patch....if you were able to commmit this in any way I would appriciate this. I promise I will deal with the paper you've sent.

Greets,

Thomas.

@deruelle

This comment has been minimized.

Member

deruelle commented Mar 29, 2016

@thaeger71 as mentioned in my earlier comments. Your patch file didn't make it to github so please add it again. What I sent is not really paper it's just a better way (and standard github way) to contribute the patch and make sure your name is attached to it as well.

thaeger71 pushed a commit to thaeger71/Restcomm-Connect that referenced this issue Mar 30, 2016

Thomas Häger
Issue RestComm#935: bug with uri-parameters in Digest, changed answer…
… to unsuccessful REGISTER to 403 FORBIDDEN, disabled keepalive (OPTIONS) even for tcp sessions
@deruelle

This comment has been minimized.

Member

deruelle commented Apr 18, 2016

Merged in #970

@deruelle deruelle closed this Apr 18, 2016

@deruelle deruelle modified the milestones: 7.6.0, 7.7.0 Apr 18, 2016

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Apr 18, 2016

Patch merged to master. Thanks @thaeger71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment