New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Guarded Logging #977

Closed
gvagenas opened this Issue Apr 4, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@gvagenas
Collaborator

gvagenas commented Apr 4, 2016

No description provided.

@gvagenas gvagenas self-assigned this Apr 4, 2016

@gvagenas gvagenas added this to the 7.6.0 milestone Apr 4, 2016

@deruelle deruelle added the tech_debt label Apr 21, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Apr 21, 2016

There is a lot of places like

logger.info("VoiceInterpreter received CallStateChanged event: "+callState);
where the logging is not guarded.

This is not good for performance. Instead the code should be guarded as in

See https://wiki.base22.com/display/btg/Java+Logging+Standards+and+Guidelines . Section Use Guarded Logging is specially important for performance.

A full review of the code base should be made for all level types (except ERROR and WARN usually) and changed to guarded logging.

@deruelle deruelle assigned zahidMed and unassigned gvagenas Apr 21, 2016

@zahidMed

This comment has been minimized.

Collaborator

zahidMed commented Apr 21, 2016

ok, It's ongoing..

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue Apr 24, 2016

RestComm#977
Fix for Windows path:
VoiceRSSSpeechSynthesizerTest
MybatisDaoManager

Use Guarded Logging for:
restcomm.application
restcomm.commons
restcomm.dao
restcomm.extension.traffic.throttling
restcomm.http
restcomm.interpreter
restcomm.mgcp
restcomm.monitoring.service
restcomm.rdv
@deruelle

This comment has been minimized.

Member

deruelle commented Apr 25, 2016

Thanks @zahidMed !
when you're done, don't forget to create a Pull Request so we can review.

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue Apr 25, 2016

RestComm#977
Use Guarded Logging for:
restcomm.mscontrol.jsr309
restcomm.mscontrol.mss
restcomm.provisioning.number.bandwidth
restcomm.sms
restcomm.telephony
restcomm.telephony.api
restcomm.tts.acapela
restcomm.tts.api
restcomm.tts.voicerss
restcomm.ussd

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue Apr 25, 2016

RestComm#977
restoring restcomm.application/src/main/webapp/WEB-INF/conf/mybatis.xml

@zahidMed zahidMed referenced this issue Apr 25, 2016

Merged

Issue 977 #1016

@gvagenas gvagenas modified the milestones: 7.6.0, 7.7.0 Apr 27, 2016

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 11, 2016

RestComm#977
Fix for Windows path:
VoiceRSSSpeechSynthesizerTest
MybatisDaoManager

Use Guarded Logging for:
restcomm.application
restcomm.commons
restcomm.dao
restcomm.extension.traffic.throttling
restcomm.http
restcomm.interpreter
restcomm.mgcp
restcomm.monitoring.service
restcomm.rdv

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 11, 2016

RestComm#977
Use Guarded Logging for:
restcomm.mscontrol.jsr309
restcomm.mscontrol.mss
restcomm.provisioning.number.bandwidth
restcomm.sms
restcomm.telephony
restcomm.telephony.api
restcomm.tts.acapela
restcomm.tts.api
restcomm.tts.voicerss
restcomm.ussd

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 11, 2016

RestComm#977
restoring restcomm.application/src/main/webapp/WEB-INF/conf/mybatis.xml

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 12, 2016

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 12, 2016

RestComm#977
Fix for Windows path:
VoiceRSSSpeechSynthesizerTest
MybatisDaoManager

Use Guarded Logging for:
restcomm.application
restcomm.commons
restcomm.dao
restcomm.extension.traffic.throttling
restcomm.http
restcomm.interpreter
restcomm.mgcp
restcomm.monitoring.service
restcomm.rdv

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 12, 2016

RestComm#977
Use Guarded Logging for:
restcomm.mscontrol.jsr309
restcomm.mscontrol.mss
restcomm.provisioning.number.bandwidth
restcomm.sms
restcomm.telephony
restcomm.telephony.api
restcomm.tts.acapela
restcomm.tts.api
restcomm.tts.voicerss
restcomm.ussd

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 12, 2016

RestComm#977
restoring restcomm.application/src/main/webapp/WEB-INF/conf/mybatis.xml

zahidMed added a commit to zahidMed/Restcomm-Connect that referenced this issue May 12, 2016

@gvagenas gvagenas modified the milestone: 7.7.0 May 13, 2016

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented May 15, 2016

Closed with PR #1016

@gvagenas gvagenas closed this May 15, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented May 16, 2016

maria-farooq pushed a commit to maria-farooq/Restcomm-Connect that referenced this issue May 17, 2016

Maria Farooq
Merge branch 'master' into issue-1070
* master: (45 commits)
  changed sections and title
  Enabled role submission from AdminUI.
  Added permission for /Usage endpoint for Developer role.
  Fixed comparison problem in AbstractEndpoint:secure() and AccountsEndpoint.
  Removed unnecessary code
  Changes getAccount() permission to Restcomm:Read:Accounts from Restcomm:Modify:Accounts.
  Fixes permission parsing and processing. - Tweaked XMLConfinguration creation from restcomm.xml so that 'comma' characters don't confuse it. - Fixed shiro permission population in Realm.java.
  added paragraph, links, details
  CheckStyle review for RestComm#977
  RestComm#977 restoring restcomm.application/src/main/webapp/WEB-INF/conf/mybatis.xml
  RestComm#977
  RestComm#977 Fix for Windows path: VoiceRSSSpeechSynthesizerTest MybatisDaoManager
  added [source,bash] and links
  made some required changes, added two paragraphs and one picture
  Properly cleanup outgoing call created with Calls API in case of a problem while downloading the RCML
  Support for dialling clients with multiple registrations This close RestComm#1033
  Fix RestComm#1026.
  Adding Documentation configuration index
  Documentation Configuration Changes
  Migration of tutorials
  ...

maria-farooq pushed a commit to maria-farooq/Restcomm-Connect that referenced this issue May 17, 2016

Maria Farooq
Merge branch 'master' into issue-5
* master: (45 commits)
  changed sections and title
  Enabled role submission from AdminUI.
  Added permission for /Usage endpoint for Developer role.
  Fixed comparison problem in AbstractEndpoint:secure() and AccountsEndpoint.
  Removed unnecessary code
  Changes getAccount() permission to Restcomm:Read:Accounts from Restcomm:Modify:Accounts.
  Fixes permission parsing and processing. - Tweaked XMLConfinguration creation from restcomm.xml so that 'comma' characters don't confuse it. - Fixed shiro permission population in Realm.java.
  added paragraph, links, details
  CheckStyle review for RestComm#977
  RestComm#977 restoring restcomm.application/src/main/webapp/WEB-INF/conf/mybatis.xml
  RestComm#977
  RestComm#977 Fix for Windows path: VoiceRSSSpeechSynthesizerTest MybatisDaoManager
  added [source,bash] and links
  made some required changes, added two paragraphs and one picture
  Properly cleanup outgoing call created with Calls API in case of a problem while downloading the RCML
  Support for dialling clients with multiple registrations This close RestComm#1033
  Fix RestComm#1026.
  Adding Documentation configuration index
  Documentation Configuration Changes
  Migration of tutorials
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment