Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement message, recording, notification, transcription filter on server side following this issue: https://github.com/RestComm/Restcomm-Connect/issues/1395 #1638
Hi @forever3000. Thanks for your patience. I did a first run through your patch. Great work there.
I noticed however there are no integration tests for the added functionality. Obviously because there were no test classes already in place. Also, no documentation is included. You think you could provide those too?
For testing, we mostly do integration testing using arquilian. It's all about adding the test class, override the default restcomm.script with another one from /resources with proper sample data and running the test.
You can get a rough idea of how this works by looking into CallsEndpointTest.java. Here are some more comments to help you get the feel of it.
Hi @otsakir ,
I nearly finish test code and I have two questions.
Thanks and Best Regards,
@forever3000 sounds great!
there is no automated tool to produce these records. I suppose for Calls, they have been copied out of production environments. This is not an option in your case. I would go with taking a sample message/notification/transcriptions record from the script file and replicating it several times. Then, manually, make the sid unique (values like SM00000000000000000000000000000001, SM00000000000000000000000000000002 should work to make your life easier) and also play a little with the dates, day-of-month etc. Then, when it comes to paging, use a small page size in your tests to verify proper operations of paging functionality. If that's the case, you can get away with 30-40 or maybe less records for each entity. It's not the best option but test-wise it covers most aspects i believe. You think that would work ?
as you will probably have noticed, restcomm documentation is part of our codebase and is written in asciidoc. The Calls API doc page seems the closest existing part documentation. List filter and Paging Information sections are what you need to supply i think.
Here they are:
So, it comes down to filling up the respective *-api.adoc documents under
I hope this helps you move forward. Ping me if you need any more feedback. I will be available tomorrow (friday) and then on Jan 4th.
@forever3000 , the review is almost finished. Master branch has been merged into your code and some fixes have been provided for the UI layer and the testsuite. I've noticed however that there are no Mybatis query files provided for the maria DB layer. Hsql is fine.
You think you could provide these too?
They are located under restcomm/restcomm.application/src/main/webapp/WEB-INF/scripts/mariadb/sql
Other that that, merging went smooth. Great job there!
Btw, you can pull the merged version of the code from forever3000-master branch from upstream repo (https://github.com/RestComm/Restcomm-Connect.git). Better to base your last touch on that if you decide to move forward.
Finally, i'm baking a binary with the latest version of this branch accessible under:
@forever3000, your branch has been reviewed and minor fixes applied. Thanks for contributing this!
@gvagenas , the patch is clear from my side. Minor manual testing has been done for mariadb too. You may proceed with merging to master. I've also committed minor fixes on top the head of the PR on main Restcomm repo: