Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
SIP Refer support to implement call transfer #1736
@vmykhailiuk , in IncomingPhoneNumbersEndpoint:createFrom() it would be better to initialize the refer* properties like for other types of requests (voice, sms, etc). For example here is how this is done for ussd:
builder.setUssdUrl(getUrl("UssdUrl", data)); builder.setUssdMethod(getMethod("UssdMethod", data)); builder.setUssdFallbackUrl(getUrl("UssdFallbackUrl", data)); builder.setUssdFallbackMethod(getMethod("UssdFallbackMethod",data)); builder.setUssdApplicationSid(getSid("UssdApplicationSid",data));
Besides the comment here, I will prepare a binary to test and will update here.
@vmykhailiuk thanks for the updates, I reviewed and accepted them. I made some modification to make the transfer method more robust and I will push to
The screenshot has not been updated but yes it's already like this. I asked @gvagenas to update the screenshot on slack.