New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1698: Preliminary UsageRecords Integration test #1766

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@abdulazizali77
Contributor

abdulazizali77 commented Feb 6, 2017

No description provided.

@otsakir otsakir added the Peer Review label Feb 6, 2017

@deruelle deruelle requested review from gvagenas and otsakir Feb 14, 2017

@deruelle

This comment has been minimized.

Member

deruelle commented Feb 14, 2017

Thanks @abdulazizali77 ! @gvagenas @otsakir can you please review ?

@abdulazizali77

This comment has been minimized.

Contributor

abdulazizali77 commented Feb 14, 2017

@deruelle @otsakir @gvagenas Sorry this isnt absolutely done yet!

@abdulazizali77 abdulazizali77 force-pushed the abdulazizali77:BUG1698 branch from a411fca to a1a6ee0 Feb 18, 2017

@abdulazizali77

This comment has been minimized.

Contributor

abdulazizali77 commented Feb 18, 2017

@otsakir Ready, please have a look
Next to implement, xml tests, dao unittests

@otsakir

This comment has been minimized.

Contributor

otsakir commented Mar 2, 2017

@abdulazizali77, i ran the tests against restcomm_with_Data.script. the following tests failed:

UsageRecordsTest.getUsageRecordsDaily
UsageRecordsTest.getUsageRecordsMonthly
UsageRecordsTest.getUsageRecordsYearly
UsageRecordsTest.getUsageRecordsAlltime

Is this expected since #1696 is not yet merged ?

@abdulazizali77

This comment has been minimized.

Contributor

abdulazizali77 commented Mar 2, 2017

@otsakir yes, failing these is a good thing :D when the rest get merged, i will update these

// archive.delete("/WEB-INF/data/hsql/restcomm.properties");
archive.addAsWebInfResource("sip.xml");
archive.addAsWebInfResource("restcomm.xml", "conf/restcomm.xml");
archive.addAsWebInfResource("restcomm_with_Data_UsageRecords.script", "data/hsql/restcomm.script");

This comment has been minimized.

@otsakir

otsakir Mar 3, 2017

Contributor

@abdulazizali77 ,the restcomm_with_Data_UsageRecords.script does not exist and i can see some new records in _restcomm_with_Data.script. So, i suppose the line above this should become:

 archive.addAsWebInfResource("restcomm_with_Data.script", "data/hsql/restcomm.script");

right ? Firist param is the name i the "resources" directory and second param the destination path inside the produced war where the file will be placed.

This comment has been minimized.

@abdulazizali77

abdulazizali77 Mar 3, 2017

Contributor

@otsakir i updated the commit, i remember adding the restcomm_with_Data_UsageRecords.script script, i guess i was wrong!
You are right about the params, but i did not intend to change/use restcomm_with_Data.script.

Issue #1698: Preliminary UsageRecords Integration test. Implement Res…
…tcommUsageRecordsTool and UsageRecords test stubs

@abdulazizali77 abdulazizali77 force-pushed the abdulazizali77:BUG1698 branch from a1a6ee0 to 85fb7ea Mar 3, 2017

@otsakir otsakir added this to the 8.1.0 milestone Mar 7, 2017

@otsakir otsakir merged commit 85fb7ea into RestComm:master Mar 7, 2017

@otsakir otsakir removed the Peer Review label Mar 7, 2017

@otsakir

This comment has been minimized.

Contributor

otsakir commented Mar 7, 2017

@abdulazizali77 , your PR has been merged. Great work work there.

Thanks for contributing! 👍

@abdulazizali77

This comment has been minimized.

Contributor

abdulazizali77 commented Mar 7, 2017

thank you @otsakir !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment