New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth number provisioning #90

Merged
merged 4 commits into from Nov 7, 2014

Conversation

Projects
None yet
5 participants
@scottbarstow
Contributor

scottbarstow commented Oct 22, 2014

Initial PR for bandwidth number provisioning

@ivelin ivelin added this to the 7.2.1 milestone Oct 22, 2014

@ivelin ivelin added the Integration label Oct 22, 2014

@ivelin

This comment has been minimized.

Contributor

ivelin commented Oct 22, 2014

Thanks Scott. Reviewing.

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Oct 22, 2014

Be gentle.

On Wed, Oct 22, 2014 at 11:22 AM, ivelin notifications@github.com wrote:

Thanks Scott. Reviewing.


Reply to this email directly or view it on GitHub
#90 (comment).

scottbarstow.com
@scottbarstow

@deruelle deruelle assigned croufay and gvagenas and unassigned gvagenas and croufay Oct 23, 2014

@deruelle

This comment has been minimized.

Member

deruelle commented Oct 23, 2014

Thanks Scott for this great contribution !

One note from my side on the documentation part, the sources-mobicents and source-telscale are automatically generated from the sources one so it's not needed to commit them. We should add them to the .gitignore in the future (@gvagenas: hint ;))

I would suggest you modify the default restcomm.xml that ships with restcomm in the restcomm.application maven module to include the bandwidth configuration (comment it by default with some comments maybe on what they represent in relation to the bandwidth account)
<bandwidth>
<username>user</username>
<password>password</password>
<accountId></accountId>
<siteId></siteId>
<uri></uri>
</bandwidth>

Also we are moving away from the jdocbook documentation to online documentation http://docs.telestax.com/restcomm-pages/.
Would you mind to add a paragraph here (or send it to us) on enabling bandwidth phone number provisioning for Restcomm Users ? Charles from our side will add it to the online docs.

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Oct 23, 2014

I will do both later today

On Thu, Oct 23, 2014 at 5:53 AM, Jean Deruelle notifications@github.com
wrote:

Thanks Scott for this great contribution !

One note from my side on the documentation part, the sources-mobicents and
source-telscale are automatically generated from the sources one so it's
not needed to commit them. We should add them to the .gitignore in the
future (@george https://github.com/George: hint ;))

I would suggest you modify the default restcomm.xml that ships with
restcomm in the restcomm.application maven module to include the bandwidth
configuration (comment it by default with some comments maybe on what they
represent in relation to the bandwidth account)

user
password

Also we are moving away from the jdocbook documentation to online
documentation http://docs.telestax.com/restcomm-pages/.
Would you mind to add a paragraph here (or send it to us) on enabling
bandwidth phone number provisioning for Restcomm Users ? Charles from our
side will add it to the online docs.


Reply to this email directly or view it on GitHub
#90 (comment).

scottbarstow.com
@scottbarstow

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Oct 23, 2014

I added the config section to the PR. Please check.

For the paragraph, let's start with:

To enable Bandwidth as your RestComm provider, you must first complete the
new account enrollment process with an account executive from Bandwidth.
Contact an account representative at 855-864-7776 to start the enrollment
process or visit http://bandwidth.com/voice for more information.

On Thu, Oct 23, 2014 at 8:03 AM, Scott Barstow sbarstow@gmail.com wrote:

I will do both later today

On Thu, Oct 23, 2014 at 5:53 AM, Jean Deruelle notifications@github.com
wrote:

Thanks Scott for this great contribution !

One note from my side on the documentation part, the sources-mobicents
and source-telscale are automatically generated from the sources one so
it's not needed to commit them. We should add them to the .gitignore in the
future (@george https://github.com/George: hint ;))

I would suggest you modify the default restcomm.xml that ships with
restcomm in the restcomm.application maven module to include the bandwidth
configuration (comment it by default with some comments maybe on what they
represent in relation to the bandwidth account)

user
password

Also we are moving away from the jdocbook documentation to online
documentation http://docs.telestax.com/restcomm-pages/.
Would you mind to add a paragraph here (or send it to us) on enabling
bandwidth phone number provisioning for Restcomm Users ? Charles from our
side will add it to the online docs.


Reply to this email directly or view it on GitHub
#90 (comment).

scottbarstow.com
@scottbarstow

scottbarstow.com
@scottbarstow

@deruelle

This comment has been minimized.

Member

deruelle commented Oct 24, 2014

Very good, Thanks.
@gvagenas will take a deeper look during the merge review
@croufay can you update the documentation to add Bandwidth as a new phone number provisioning provider including the paragraph @scottbarstow provided in his comments above ?

@croufay

This comment has been minimized.

Contributor

croufay commented Oct 24, 2014

Hi Jean,

It will be nice if we could test Bandwidth's configuration before we
proceeed.

Is there a way to go about that?

Regards

Charles

On Fri, Oct 24, 2014 at 6:50 AM, Jean Deruelle notifications@github.com
wrote:

Very good, Thanks.
@gvagenas https://github.com/gvagenas will take a deeper look during
the merge review
@croufay https://github.com/croufay can you update the documentation to
add Bandwidth as a new phone number provisioning provider including the
paragraph @scottbarstow https://github.com/scottbarstow provided in his
comments above ?


Reply to this email directly or view it on GitHub
#90 (comment).

@gvagenas gvagenas merged commit 5fe2316 into RestComm:master Nov 7, 2014

@gvagenas

This comment has been minimized.

Collaborator

gvagenas commented Nov 7, 2014

Thanks for your work here, I just merge the work to the master branch.

@scottbarstow

This comment has been minimized.

Contributor

scottbarstow commented Nov 7, 2014

Great, thanks!

On Fri, Nov 7, 2014 at 9:39 AM, George Vagenas notifications@github.com
wrote:

Thanks for your work here, I just merge the work to the master branch.


Reply to this email directly or view it on GitHub
#90 (comment).

scottbarstow.com
@scottbarstow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment