New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support init password #48

Merged
merged 4 commits into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
@hamsterksu
Collaborator

hamsterksu commented Mar 28, 2016

No description provided.

@hamsterksu

This comment has been minimized.

Collaborator

hamsterksu commented Mar 28, 2016

@deruelle i have created new pull request

@deruelle

This comment has been minimized.

Member

deruelle commented Mar 29, 2016

@leftyb please review and merge

@leftyb

This comment has been minimized.

Contributor

leftyb commented Mar 29, 2016

hi @hamsterksu,

I am testing the modification and in a specific case where HSQL_PERSIST is used the modification is not working.

As you can see here the script is copying restcomm.script to the new defined location. Can you please fix that. What you need to do is to include the modification for INIT_PASSWORD before HSQL_PERSIST at "restcomm_conf.sh" script.

Thank you,
Lefteris.

@hamsterksu

This comment has been minimized.

Collaborator

hamsterksu commented Mar 29, 2016

@leftyb done, i suppose we should split this file by sections.

@leftyb

This comment has been minimized.

Contributor

leftyb commented Mar 29, 2016

@hamsterksu,

Thank you very much. I will merge your contribution now.
We are in a process of refactoring the docker configuration scripts, so for now, I think that we will leave it like that, until we get the refactoring done.

B.R.

@leftyb leftyb merged commit a18dcce into RestComm:master Mar 29, 2016

@hamsterksu

This comment has been minimized.

Collaborator

hamsterksu commented Mar 29, 2016

@leftyb thanks, i have one more PR i will push it in 15 min.

@leftyb

This comment has been minimized.

Contributor

leftyb commented Mar 29, 2016

@hamsterksu Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment