New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable internal mediaserver #65

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
2 participants
@leftyb

This comment has been minimized.

Contributor

leftyb commented May 6, 2016

Hi @hamsterksu,

You are right. Can you please add the same variable as well at: https://github.com/RestComm/Restcomm-Docker/blob/master/scripts/restcomm_setenv.sh

So it can be configured from the RUN command and update the PR.

Thank you.

@hamsterksu

This comment has been minimized.

Collaborator

hamsterksu commented May 6, 2016

@leftyb do you prefer separate variable?
i think we should setup it automatically when user provides $MS_ADDRESS

Also if we are going to expose all restcomm config variables maybe we can use some template like
CONFIG_variable and process them automatically like
https://github.com/RestComm/mediaserver-docker/blob/master/scripts/configure.sh#L28

@leftyb

This comment has been minimized.

Contributor

leftyb commented May 6, 2016

@hamsterksu
You are right my fault, activating it automatically is Ok. I will merge the contribution.

On the "CONFIG_variable" I noticed your approach at RMS docker. Seems a good solution to me. Lets discuss on that when the refactoring of auto-configuration scripts is ready.

Thank you.

@leftyb leftyb merged commit ab99f54 into RestComm:master May 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment