New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping validation of DeliveryReceipt (e.g. network_error_code size) #15

Closed
JChrist opened this Issue Jun 9, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@JChrist

JChrist commented Jun 9, 2017

Hello.
I wanted to ask if this fork is being actively maintained and if there are any new versions with bug fixes coming out of it (and at which maven coordinates?).
Also, is version coming out with netty 4 (from netty4 branch) being maintained as well?
The reason I am asking is because I am using version with netty4 and I wanted to address issue mentioned here: fizzed#10 and I would be happy to contribute for it, but I'm not at all sure if there is any currently actively maintained repo for cloudhopper.

@vetss

This comment has been minimized.

vetss commented Jun 9, 2017

Hello @JChrist

I wanted to ask if this fork is being actively maintained and if there are any new versions
with bug fixes coming out of it

Yes, this fork is being actively maintained for both master and netty-4 branches.

@JChrist JChrist changed the title from Status of fork to Allow skipping validation of DeliveryReceipt (e.g. network_error_code size) Jun 9, 2017

@JChrist

This comment has been minimized.

JChrist commented Jun 9, 2017

@vetss That's good to hear!
I was thinking of providing a new method with a signature of:
static public DeliveryReceipt parseShortMessage(String shortMessage,
DateTimeZone zone, boolean checkMissingFields, boolean validateFields)
throws DeliveryReceiptException

By default the existing method would delegate calls to the new one with true for validateFields (providing backwards-compatibility), meanwhile allowing one to call it with false, thus not throwing exceptions if field validation fails. Specifically for error code field, it will call the setRawErrorCode method in DeliveryReceipt, so as to keep the raw error code, even if it's more than 3 characters.

What do you think?

@vetss

This comment has been minimized.

vetss commented Jun 9, 2017

@JChrist sorry I am not so deeply aware for mentioned by you methods.
Feel free to add PRs if you mean we need some fixes. Pease take into account that we need updates for both master and netty-4 branches if an update is for staff in both branches

@vetss

This comment has been minimized.

vetss commented Jun 15, 2017

Hello @JChrist

I added your upadate into master and netty4 branches:
#18

And I also added "slf4j.version" into a root pom.

Thanks for your work. I see that you provide abackup compatibility that is good.
Please provide your testing results.

@vetss

This comment has been minimized.

vetss commented Jun 15, 2017

@JChrist

This comment has been minimized.

JChrist commented Jun 23, 2017

thanks a lot @vetss for your help and review!

@JChrist JChrist closed this Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment