New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route requests to protocol specific methods in MobileCoreNetworkInterfaceSbb #50

Closed
Vanit opened this Issue Jul 13, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@Vanit
Collaborator

Vanit commented Jul 13, 2016

Currently https://github.com/RestComm/gmlc/blob/master/core/slee/services/sbbs/src/main/java/org/mobicents/gmlc/slee/MobileCoreNetworkInterfaceSbb.java responds to all request URIs and handles protocols based on the request type (GET -> rest, POST -> mlp). Ideally there should a different URI per protocol that's mapped to its own method, ie:

  • /restcomm/gmlc/rest -> void rest(params)
  • /restcomm/gmlc/mlp -> void mlp(params)
  • /restcomm/gmlc/sip -> void sip(params)
  • else -> void 404(params)

It should be noted that the /restcomm part of the URI is determined by the http-servlet and the code should just work if it's changed.

As we just need to do simple URI -> method routing I'd suggest writing a small class (or even method) to handle it.

@Vanit

This comment has been minimized.

Collaborator

Vanit commented Jul 13, 2016

Assign to me please :)

@FerUy

This comment has been minimized.

Contributor

FerUy commented Jul 13, 2016

All yours ;)

@FerUy

This comment has been minimized.

Contributor

FerUy commented Jul 26, 2016

@monix any update from your side on this?

@Vanit

This comment has been minimized.

Collaborator

Vanit commented Jul 26, 2016

@FerUy I've been swamped at work for the last week so no progress, but I'm about to free up so should have something either today or tomorrow :)

@FerUy

This comment has been minimized.

Contributor

FerUy commented Jul 26, 2016

Great!
Thanks for the quick update @monix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment