New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS NAPTR record Service field is compared in Case Sensitive manner #1

Closed
gkumar78 opened this Issue Sep 14, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@gkumar78
Contributor

gkumar78 commented Sep 14, 2015

Recently noticed that DefaultDNSLookupPerformer class of this Mobicents extension is comparing Service field of returned NAPTR RRs with defined Service protocols of "D2U" and "D2T" in case-sensitive manner. Hence, when returned NAPTR records have lowercase values in Service fields ("SIP+d2t" or "sip+d2u"), they result in a mismatch and ignored for further SRV lookup.

However, the base NAPTR RR RFC 2915 indicates in Section 2, Page 6 that the case of the alphabetic characters is not significant for Service field value. Hence, SIP+D2U should be treated same as sip+d2u.

@deruelle deruelle added the bug label Sep 18, 2015

@deruelle

This comment has been minimized.

Member

deruelle commented Sep 18, 2015

Thanks for reporting it. Can you contribute a fix for this and do a Pull Request ?

@gkumar78

This comment has been minimized.

Contributor

gkumar78 commented Sep 28, 2015

I have proposed fix for this with Pull request. Please check

@deruelle

This comment has been minimized.

Member

deruelle commented Sep 28, 2015

Ah great didn't see it before, sorry about that. Can you sign the contributor license agreement at http://www.telestax.com/open-source-2/#Contribute so we can accept the Pull Request ?

Thanks in advance

@deruelle

This comment has been minimized.

Member

deruelle commented Oct 10, 2015

Let me know when you had time to sign the CLA so that we can accept the contribution. Thanks

@gkumar78

This comment has been minimized.

Contributor

gkumar78 commented Dec 2, 2015

I have signed Corporate CLA as Infosys Developer in name of Girish Kumar. Hope you can accept the patch now

@deruelle

This comment has been minimized.

Member

deruelle commented Dec 2, 2015

Thanks I have accepted the pull request. Do you want to be acknowledged at http://www.telestax.com/open-source-2/acknowledgments/- ? If so do you want me to link to your linkedin profile ?

@deruelle

This comment has been minimized.

Member

deruelle commented Dec 11, 2015

@deruelle deruelle closed this Dec 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment