New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator specific Trigger-Type Ro interface AVP value #21

Closed
gfigiel opened this Issue Feb 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@gfigiel
Contributor

gfigiel commented Feb 7, 2017

Hello,
We have implemented extensions to diameter Ro RA. In scope of the project we implemented additional (non-standard) value for Trigger-Type AVP.
The value is 999 (new emum created) and causes diameter session to be served in degraded mode.

We agreed our Customer to contribute this extension so the question is to community now... Shall we include non-standard extensions to current diameter implementation?

gfigiel added a commit to ProIDS/jain-slee.diameter that referenced this issue Feb 7, 2017

Fix for issue RestComm#21 Trigger-Type AVP values alligned with 3GPP …
…TS 32.299 V8.25.0 and custom value (999) implemented.
@gfigiel

This comment has been minimized.

Contributor

gfigiel commented Feb 7, 2017

Hello,
Please see the PR for this issue. I believe there is no much backward compatibility issue risk.
The only issue I can see is in scenario when some peer will generate the same, erronous AVP value by conicidence and it will be wrongly accepted by stack (customized) instead of raise an Exception.

@deruelle

This comment has been minimized.

Member

deruelle commented Feb 21, 2017

Closed from #22

@deruelle deruelle closed this Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment