New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update - empty HTTP response event processing description #7

Closed
tzieleniewski opened this Issue Mar 31, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@tzieleniewski
Collaborator

tzieleniewski commented Mar 31, 2016

When there is an IOException during the HTTP method execution, RA fires an empty HTTP Response Event, where HTTP response object is null. Situation applies both in HTTP Client RA and HTTP Client NIO RA.

Such situation, if not processed correctly, leads to runtime NPE exception.
SBBs, during response event processing, should first call ResponseEvent#getException method and only if that gives back null then they should call ResponseEvent#getHttpResponse.

@tzieleniewski

This comment has been minimized.

Collaborator

tzieleniewski commented Apr 6, 2016

Pull request created: #8

@deruelle

This comment has been minimized.

Member

deruelle commented Apr 6, 2016

@SergeyLee please review

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Apr 25, 2016

Ok, I reviewed issue and pull request. I splited your commit into 2 commits: refactorizing Maven pom.xml files and updating documentation.

@SergeyLee SergeyLee closed this Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment