New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of Apache HTTP libraries version #12

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
3 participants
@yarel79
Contributor

yarel79 commented Dec 6, 2016

PR to introduces the following chanages for issue/10:

  • version of HTTP libraries upgraded from "beta" to the most stable up2date
  • backward compatibility of HTTP NIO RA broken (HttpClientNIOResourceAdaptorSbbInterface no longer exposes: HttpParams getHttpClientParams(); operation)
  • version of RA bumped from 1.0 to 2.0

Impact on existing instllations:

  • version of RA needs to be considered on deployment
  • If HTTP_CLIENT_FACTORY used for RA, then new version of org.apache.http.nio.client.HttpAsyncClient should be considered
@deruelle

This comment has been minimized.

Member

deruelle commented Dec 6, 2016

Thanks @yarel79. @SergeyLee can you review ?

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Dec 16, 2016

I reviewed this PR and builded project entirely. Fixed some HttpParams usage in http-client-nio.
Also we need to update http-client with removing HttpParams usage as it deprecated.

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Dec 16, 2016

So I will merge this PR and create new issue for updating http-client. But now I cannt test it in real example and I will test it with new JSLEE 3 in near future.
Thanks to @yarel79 @jaimecasero !

@SergeyLee SergeyLee merged commit f4af06d into RestComm:master Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment