New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update - SBB code examples - response event handling #8

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tzieleniewski
Collaborator

tzieleniewski commented Apr 6, 2016

References: #7
Updated documentation SBB code examples with information about 'empty' HTTP response event processing.
Updated POM files formatting.

tzieleniewski
- updated documentation SBB code examples with information about 'emp…
…ty' HTTP response event processing

- updated POM files formatting

@tzieleniewski tzieleniewski changed the title from Updated documentation SBB code examples to Documentation update - SBB code examples Apr 6, 2016

@tzieleniewski tzieleniewski changed the title from Documentation update - SBB code examples to Documentation update - SBB code examples - response event handling Apr 6, 2016

@deruelle deruelle added the enhancement label Apr 6, 2016

tzieleniewski
The default HTTP response code changed from 200 to 501 Not Implemented
Refactorized Maven pom.xml files (properties, version).
@tzieleniewski

This comment has been minimized.

Collaborator

tzieleniewski commented Apr 22, 2016

References as well #9 (HTTP Servlet RA - default HTTP response status change).

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Apr 25, 2016

Hi Tomasz!
I'll review your PR today.
But in future please divide changes on several commits. One commit on changes formatting. Other commits on main changes.

Best regards
Sergey Lee

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Apr 25, 2016

I tried to build project: mvn clean install, and I have errors:

[ERROR] /home/sergeypovarnin/Projects/MobiusRepo/jain-slee.http/resources/http-client-nio/ra/src/main/java/org/mobicents/slee/ra/httpclient/nio/ra/HttpClientNIOResourceAdaptor.java:[123,22] error: cannot find symbol
[ERROR] variable httpclient of type HttpAsyncClient
/home/sergeypovarnin/Projects/MobiusRepo/jain-slee.http/resources/http-client-nio/ra/src/main/java/org/mobicents/slee/ra/httpclient/nio/ra/HttpClientNIOResourceAdaptor.java:[153,27] error: cannot find symbol
[ERROR] variable httpclient of type HttpAsyncClient
/home/sergeypovarnin/Projects/MobiusRepo/jain-slee.http/resources/http-client-nio/ra/src/main/java/org/mobicents/slee/ra/httpclient/nio/ra/HttpClientNIOResourceAdaptorSbbInterfaceImpl.java:[41,22] error: cannot find symbol
[INFO] 3 errors

If I build project without your changes it builds successful.
Now I am investigating what is wrong in pom.xml changed by you.

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Apr 25, 2016

Ok. I found reason: in parent pom.xml you fixed version for httpasyncclient from 4.0-beta3 to 4.0.

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Apr 25, 2016

I decided to leave httpasyncclient 4.0-beta3 for now.
But I will create issue for updating httpasyncclient to 4.0 or higher version.

@SergeyLee SergeyLee closed this Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment