New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raActive() doesn't allow to change CACHE_CLASS_NAME #19

Closed
yarel79 opened this Issue Aug 29, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@yarel79
Contributor

yarel79 commented Aug 29, 2016

It is not possible to provide own CACHE_CLASS since RA on raActive() hardcodes specific class name.

In the SipResourceAdaptor.java file you can find block like:
// define impl of the cache of the HA stack
properties.setProperty(ClusteredSipStack.CACHE_CLASS_NAME_PROPERTY,SipResourceAdaptorMobicentsSipCache.class.getName());`

Reason:
I would like to mock this class on for some unit testing, but current implementation of the RA limits that.

@yarel79

This comment has been minimized.

Contributor

yarel79 commented Aug 31, 2016

Proposed fix is under: yarel79@22f29de

@deruelle

This comment has been minimized.

Member

deruelle commented Aug 31, 2016

Thanks @yarel79

Can you do a pull request as described in our Open Source Playbook Pull Request Section ?

Also could you sign our contributor license agreement so we can accept the contribution and acknowledge you on https://telestax.com/acknowledgements ?

@deruelle

This comment has been minimized.

Member

deruelle commented Sep 14, 2016

Pull request is at #22

SergeyLee added a commit that referenced this issue Sep 21, 2016

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Sep 21, 2016

I merged your branch yarel79-issue/19 with adding cacheClassName property to deploy-config.xml and raConfigure(), raActive().

@yarel79 yarel79 closed this Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment