New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogWrapper.delete() - NullPointerException #29

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
4 participants
@yarel79
Contributor

yarel79 commented Oct 30, 2016

delete() now considers case when wrappedDialog object is not present. This is a fix for #25

@deruelle

This comment has been minimized.

Member

deruelle commented Oct 30, 2016

Thanks @yarel79. @jaimecasero @SergeyLee can you review ?

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Nov 28, 2016

Yes, there is must be checking wrappedDialog object on null before deleting it and checking if it Server or Client dialog wrapper.
I will test this fix locally before merging.

@SergeyLee

This comment has been minimized.

Contributor

SergeyLee commented Nov 29, 2016

I have tested this fix with SIP tests locally and all tests were passed. So I will merge it in master branch.
Thank you, @yarel79, for this fix!

@SergeyLee SergeyLee merged commit d82de32 into RestComm:master Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment