New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality fix - Local Variables should not be declared and then immediately returned or thrown. #25

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@faisal-hameed
Contributor

faisal-hameed commented Mar 17, 2016

This pull request is focused on resolving occurrences of Sonar rule
squid:S1488 - Local Variables should not be declared and then immediately returned or thrown.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1488

Please let me know if you have any questions.

Faisal Hameed

@satanatoly satanatoly merged commit 285c794 into RestComm:master Feb 21, 2018

satanatoly pushed a commit that referenced this pull request Feb 21, 2018

Fixing squid:S1858 - "toString()" should never be called on a String …
…object. (#32)

Fixing squid:S1481 - Unused local variables should be removed. (#31)
Fixing squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. (#30)
Fixing squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used (#29)
Fixing squid:S1155 - Collection.isEmpty() should be used to test for emptiness. (#28)
Fixing squid:S1905 - Redundant casts should not be used. (#27)
Fixing squid:S2131- Primitives should not be boxed just for "String" conversion. (#26)
Fixing squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. (#25)

satanatoly pushed a commit that referenced this pull request Feb 21, 2018

Fixing squid:S1488 - Local Variables should not be declared and then …
…immediately returned or thrown. (#25)

Fixing squid:S2131- Primitives should not be boxed just for "String" conversion. (#26)
Fixing squid:S1905 - Redundant casts should not be used. (#27)
Fixing squid:S1155 - Collection.isEmpty() should be used to test for emptiness. (#28)
Fixing squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used (#29)
Fixing squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. (#30)
Fixing squid:S1481 - Unused local variables should be removed. (#31)
Fixing squid:S1858 -  "toString()" should never be called on a String object. (#32)
@faisal-hameed

This comment has been minimized.

Contributor

faisal-hameed commented Feb 24, 2018

Thanks @deruelle and @satanatoly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment