New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rx client not sending properly application ID #121

Closed
Neloop opened this Issue Dec 23, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@Neloop
Contributor

Neloop commented Dec 23, 2017

Hello,
I am trying to use jdiameter as Gx and Rx client for PCRF server and I've come to some difficulties with Rx interface. For Gx all works as expected, messages are sent properly and server can answer to them. However using Rx client it is not possible to send messages with proper application ID set. I track down the issue and it seems that session factory for Rx interface is not setting application ID properly during creation of new session.

Gx session factory has this line of code: https://github.com/RestComm/jdiameter/blob/1.7.1-114/core/jdiameter/impl/src/main/java/org/jdiameter/common/impl/app/gx/GxSessionFactoryImpl.java#L274

Which is missing in Rx session factory: https://github.com/RestComm/jdiameter/blob/1.7.1-114/core/jdiameter/impl/src/main/java/org/jdiameter/common/impl/app/rx/RxSessionFactoryImpl.java#L298

Thus sent message, for example AAR has application ID set to 0 and my server is not able to route the request to proper listener. Is this intended behaviour to ignore application ID or is it a bug?

Thanks in advance

@gsaslis

This comment has been minimized.

Contributor

gsaslis commented Dec 27, 2017

Hi @Neloop,

Thanks for raising this! From my POV, this does look like a bug.
Would you mind opening a PR for this please?

@Neloop

This comment has been minimized.

Contributor

Neloop commented Dec 27, 2017

Hello,
of course, can do... in a few days

@gsaslis

This comment has been minimized.

Contributor

gsaslis commented Dec 27, 2017

@Neloop Awesome!!

yeah, sure, no rush. @ammendonca (who will be reviewing - hint, hint Alex ;) ) is also out for a few days afaik, so we can wait for you even till next year ...

@Neloop

This comment has been minimized.

Contributor

Neloop commented Dec 31, 2017

Deploy to https://oss.sonatype.org would be nice after integration of my PR ;-)
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment