New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parseDictionary in order to load the file or InputStream passed b… #115

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@marinofernandes

marinofernandes commented Jul 23, 2017

…y argument

2 new APIs (getInstance(String confFile) and getDictionary(InputStream is)) where created on DictionaryImpl and DictionarySingleton;
Previous behaviour was maintained and its available using parseDictionary((InputStream) null)
ParseDictionary API was changed and nameToCodeMap TreeMap was converted in HashMap to improve performance

Marino Fernandes
Fix parseDictionary in order to load the file or InputStream passed b…
…y argument

2 new APIs (getInstance(String confFile) and getDictionary(InputStream is)) where created on DictionaryImpl and DictionarySingleton;
Previous behaviour was maintained and its available using parseDictionary((InputStream) null)
ParseDictionary API was changed and nameToCodeMap TreeMap was converted in HashMap to improve performance
@ammendonca

This comment has been minimized.

Collaborator

ammendonca commented Jul 27, 2017

Thanks @marinofernandes! The fix looks good, keeps compatibility and it's great that it includes some extra performance improvements.

Merging.

@ammendonca ammendonca merged commit f5d6c20 into RestComm:master Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment