New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jEIR to use latest JAIN SLEE (v2.8.10.32) and jSS7 (v3.0.1322) #6

Merged
merged 2 commits into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@mnowa
Collaborator

mnowa commented Jan 14, 2016

Updating jEIR to work with latest JAIN SLEE (v2.8.10.32) and jSS7 (v3.0.1322) releases. This should be enough to close issue #1

@deruelle

This comment has been minimized.

why the change to com.telscale instead of org.mobicents ?

This comment has been minimized.

Owner

mnowa replied Jan 15, 2016

Well, this is because in latest jSS7 version(3.0.13.22) in there is no more org.mobicents.ss7.management.console.ShellServer class Instead there is a class com.telscale.ss7.management.console.ShellServer inside shell-server-impl-3.0.1322.jar
I didn't four the org.mobicents.ss7.management.console.ShellServer class in latest jSS7 version (it has been moved/refactored to the com.telscale package?)
Did I missed something?

This comment has been minimized.

deruelle replied Jan 15, 2016

mmm that's not good. let me check with the SS7 Team so they change that.

This comment has been minimized.

deruelle replied Jan 15, 2016

RestComm/jss7#27. I'll ping you when that's fixed on the SS7 Side

This comment has been minimized.

Owner

mnowa replied Jan 15, 2016

BTW,
Actually the change in ShellServer class is biger (now ShellServer class uses JBOSS AS classes like org.jboss.security.plugins.JaasSecurityManager). Because of this existing jEIR test application throws ClassNotFound runtime exception when using latest jSS7 libs (shell-server-impl-3.0.1322.jar)

This comment has been minimized.

deruelle replied Jan 19, 2016

It has been fixed now in build #1323 https://mobicents.ci.cloudbees.com/job/Mobicents-jSS7/. Could you update to it and change those references to com.telscale by org.mobicents ? Thanks in advance

This comment has been minimized.

Owner

mnowa replied Jan 20, 2016

I've update jEIR with jSS7 v3.0.1323 changes. Should I commit and changes to the same issue#1 branch as pointed in the pull request?

This comment has been minimized.

deruelle replied Jan 20, 2016

@deruelle

This comment has been minimized.

It should be Mobicents-jEIR not TelScale

This comment has been minimized.

Owner

mnowa replied Jan 15, 2016

Sure, I will correct it

@deruelle

This comment has been minimized.

why commenting those properties ?

This comment has been minimized.

Owner

mnowa replied Jan 15, 2016

Those properties can't acttually be set. I have tested it. Attempt to set them will couse following exceptions:
DialogIdleTimeout parameter can be updated only when TCAP stack is running
InvokeTimeout parameter can be updated only when TCAP stack is running
MaxDialogs parameter can be updated only when TCAP stack is running

See org.mobicents.protocols.ss7.tcap.TCAPStackImpl class from tcap-impl-3.0.13.22.jar for more details.

BTW,
The properties vaules used in xml fiel are the same as default values used by TCAPStackImpl class

This comment has been minimized.

deruelle replied Jan 15, 2016

OK Understood. Thanks

@deruelle

This comment has been minimized.

why not keep it a constant, this is best practice AFAIK for logger classes as they often heavily accessed

This comment has been minimized.

Owner

mnowa replied Jan 15, 2016

Ok I will rolback this change. I didn't know this good practice

@deruelle deruelle merged commit 7d99d94 into RestComm:master Jan 20, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Jan 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment