Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding some missing XML serializations to the CAP stack #103
I have committed your updates into netty-2 branch. We have stopped to add new updates into master branch because we will release it soon. Then we will rename betty-2 to master.
Also I added an extra fix. I think that SpecializedResourceReportRequestImpl was not made in the best way. Please check my update. (I also made some extra code changes for code style).
referenced this issue
Jun 2, 2016
Thank you for fixing and merging our mods.
I'd like to discuss the handling of default values in general.
When decoding ASN.1 data, a missing optional parameter with a default value must always be parsed as if the default value was there in the data. We think that it is a good idea to use the same logic in XML parsing as well. For this reason, we always assign the default value to the parameter first, and only update it if a contradicting value is present in the input data.
I'd like to hear your opinion about this topic because the next updates I am preparing contain default value handling too.
fill free to provide PR even for a master branch if they are ready. I will check and add commits into netty-2 branch. But please add new PR to code based on netty-2 branch.
As for treating of absense of XML parameters (that have a default value) as a default value (and not null) as it occurs at SS7 part: we always added into the XML part parameters even they have default values and decode they also without caring of default values. Your approach also makes sense of cause, but the issue that we followed previously in another style and this means behaviour changing that we need to avoid in code update as much as possible.
So let's encode all non-null parameters even they have default values.