New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPErrorMessageParameterlessImpl toString() mod #113

Closed
AlerantAppNGIN opened this Issue Jun 7, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@AlerantAppNGIN
Collaborator

AlerantAppNGIN commented Jun 7, 2016

Hello @vetss

In our fork in the toString() method of the CAPErrorMessageParamerlessImpl class we converted the errorCodes to human readable messages. I'll send a PR for this issue so you can merge it if you like this tiny mod.

Best Regards,
Gabor

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 9, 2016

Hello @AlerantAppNGIN,

I have commented you PR #114 into netty-2 branch. Thanks for your work. I have only added into toString() methods also a numeric valuu so it returns now values like
"0:canceled".
Somebody needs also digital values. I believe it is good enouph for you too.

Fixed by:
d048192
01d4a75

@vetss vetss closed this Jun 9, 2016

@AlerantAppNGIN

This comment has been minimized.

Collaborator

AlerantAppNGIN commented Jun 9, 2016

Hello @vetss ,

Thank you for commiting the PR and I am also agree with your modification of course.

Brgds,
Gabor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment