New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAP Apply Charging handling improvments #115

Closed
AlerantAppNGIN opened this Issue Jun 7, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@AlerantAppNGIN
Collaborator

AlerantAppNGIN commented Jun 7, 2016

Hello,

I extracted some mods from our fork here is the description of modifications and I'll also send a PR which makes things even clearer :-)

Description:

  • Added concrete CAP version to InitialDP instead of "isCapVersion3OrLater".
  • Fixed LegID encoding in AChChargingAddress.
  • Improved CAP phase (3-4) handling in CAMELAchBillingChargingCharacteristicsImpl by replacing "isCap3OrLater" with explicit CAP version.
    • Changed XML serialization to honor the default value of legActive the same way as the ASN.1 encoding does.
    • Modified CAPFuntionalTest to use the default values pf AChChargingAddress in AChBillingChargingCharacteristics and TimeDuration objects
    • Modified ApplyChargingRequestTest to use the default values of the partyToCharge
      and AChChargingAddresses fields
    • In the AudibleIndicatorTest a new test case is added to both the decode and the encode test methods
    • In the CAMELAChBillingChargingCharacteristicsTest a new test case is addded to bothe the decode and encode methods and fixed the encoding/decoding of the AudibleIndicator field.
    • In the testDecode method of TimeDurationChargingResultTest fixed the handling of AChChargingAddress field.

Regards,
Gabor

@deruelle deruelle added the enhancement label Jun 7, 2016

@deruelle deruelle added this to the 7.1.0 milestone Jun 7, 2016

vetss added a commit to vetss/jss7 that referenced this issue Jun 10, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 10, 2016

Hello @AlerantAppNGIN

thank you for provided update in #116. I have not committed it fully (it is little bit complicated) but created a cunulative commit for code updates that we can accept:
8836b03

My comments:

  1. thank you for a catch and provided code for wrong implemented CAMELAchBillingChargingCharacteristicsImpl. I include most of your code but with several changes for minimizing of changes. Please check my update.

  2. When we were implementing primitives like "BOOLEAN DEFAULT FALSE" (with default) values we thought of two type of options:
    a) decode just what has come from a peer and let a CAP user use of some default value if a parameter is null
    b) fill a default value at the step of decoding
    We decided to follow "a)" way so not filling of any default value. The same we do at XML serializing. Let's not change existing behavior as much as it possible. The same if for "Added concrete CAP version to InitialDP instead of "isCapVersion3OrLater"." - I have not added this update in order not to breake current behaviour.

Please ley me know if you have some remarks for mu update.

@vetss vetss modified the milestones: Sergey-8.0-sprint1, 8.0.0 Jul 23, 2017

@knosach knosach modified the milestones: Sergey-8.0-sprint1, 8.0.0 Mar 5, 2018

@knosach knosach closed this Mar 5, 2018

@gsaslis

This comment has been minimized.

Contributor

gsaslis commented Mar 6, 2018

@knosach is this closed as invalid nowadays, or fixed?

@knosach

This comment has been minimized.

Contributor

knosach commented Mar 7, 2018

hi @gsaslis it was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment