New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling malformed TCAP UserInformation #121

Closed
AlerantAppNGIN opened this Issue Jun 8, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@AlerantAppNGIN
Collaborator

AlerantAppNGIN commented Jun 8, 2016

Hello,

This issue is raised when we found that one of the MSS in our telecommunication network tends to send malformed User Information in TC-BEGIN messages. When this happens JSs7 throws a parse Exception and drops the entire message. Since in our case the malformed User Information doesn't hold any meaningful information we modified the JSs7 code to ignore this error.
I really wish that I could send a bug ticket to the vendor of that legacy network device and just wait until they fix this bug and patch all the device they sold. But it is not possible so we have to find a solution for this issue.
I'll attach a PR containing our solution. We modified the parsing of User Information to ignore the parse exception and set a flag which represents that there was a malformed user information in the message.
I personally don't think that this is the best solution. Maybe we should make configurable at TCAP stack level that JSss7 should ignore or not malformed User Information. An other solution could be to make a statement that these kind of vendor specific issues are out of scope of the JSs7 library and propose to use a vendor specific fork of the JSs7 project.
Please, let me know what you think of this issue.
Thanks in forward.
Best Regards,
Gabor

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 10, 2016

Hello @AlerantAppNGIN

I have committed you request into netty-2 branch and added also you new getter into an interface.
a855625
fefb3a1

Thanks for your update.

@vetss vetss closed this Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment