New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic: Implementing some API features in CAP InitialDPRequestImpl #125

Closed
AlerantAppNGIN opened this Issue Jun 9, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@AlerantAppNGIN
Collaborator

AlerantAppNGIN commented Jun 9, 2016

Hello,

I extracted the following feautres from our JSs7 fork:

Topic: Implementing some API features in CAP InitialDPRequestImpl
Description:
Added the missing ASN.1/XML encoding/decoding implementation for
some parameters in InitialDPRequestImpl.

Added the missing ASN.1/XML encoding/decoding implementation for
most of the parameters in InitialDPArgExtensionImpl.

Added utility methods to OctetStringBase to allow subclasses to
easily read/write their byte[] data as hex strings to/from XML.

I'll attach a PR to this issue please review it.

Thanks!

Best Regards,
Gabor

@vetss vetss added the enhancement label Jun 10, 2016

@vetss vetss added this to the 7.1.0 milestone Jun 10, 2016

@vetss vetss self-assigned this Jun 10, 2016

vetss added a commit to vetss/jss7 that referenced this issue Jun 10, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 10, 2016

Hello @AlerantAppNGIN

I have fixed your topic by this commit:
ec420c2
(I failed to add your commits directly)

I have not added changing of capVersion boolean->enum to keep a backword compatibility
Thanks for your work

@vetss vetss closed this Jun 10, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 16, 2016

Hello @AlerantAppNGIN

you can check the example of XML payload which we use for CAMEL GW:
https://github.com/RestComm/camelgateway/blob/master/core/xml/src/main/java/org/restcomm/camelgateway/XmlCAPDialog.java

The example of payload that we get from CAMEL GW is:

<?xml version="1.0" encoding="UTF-8" ?>
<dialog appCntx="CapV4_gsmSSF_scfGeneric" networkId="11" localId="1" remoteId="2" capMessagesSize="1" returnMessageOnError="false" redirectRequest="false">
    <origAddress pc="2" ssn="146">
        <ai value="83"/>
        <gt type="GlobalTitle0100" tt="0" es="1" np="1" nai="4" digits="2222201"/>
    </origAddress>
    <destAddress pc="0" ssn="8">
        <ai value="18"/>
        <gt type="GlobalTitle0100" tt="0" es="1" np="1" nai="4" digits="1111112"/>
    </destAddress>
    <errComponents/>
    <initialDP_Request invokeId="1" isCAPVersion3orLater="true">
        <serviceKey value="1"/>
        <calledPartyNumber>
            <isupCalledPartyNumber address="111222" natureOfAddresIndicator="4" numberingPlanIndicator="1" internalNetworkNumberIndicator="0"/>
        </calledPartyNumber>
    </initialDP_Request>
</dialog>

This is an example how you can obtain CAMEL version as the best practice

@AlerantAppNGIN

This comment has been minimized.

Collaborator

AlerantAppNGIN commented Jun 17, 2016

Hi @vetss,

Thank you for sharing us the above code example.
We are thinking of changing our interface between IM-SCF and Application servers to increase its flexibility and compatibility with existing systems. So your ideas felt on a fertile ground, so to speak :-)

I think we can agree that we only serialize CAP version in a primitive if it is used in its encoding/decoding logic.

Brgds,
Gabor

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 17, 2016

Hello @AlerantAppNGIN

ok, thanks for your update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment