New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAP FCI SMS xml serialization #127

Closed
AlerantAppNGIN opened this Issue Jun 10, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@AlerantAppNGIN
Collaborator

AlerantAppNGIN commented Jun 10, 2016

Hello,

I'd like to add XML serialization to the class that implement the FCI SMS function.
I'll send a PR to this issue.

Best Regards,
Gabor

@vetss vetss added the enhancement label Jun 10, 2016

@vetss vetss added this to the 7.1.0 milestone Jun 10, 2016

@vetss vetss self-assigned this Jun 10, 2016

vetss added a commit to vetss/jss7 that referenced this issue Jun 10, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 10, 2016

Hello @AlerantAppNGIN

I have accepted your update into a single commit (into netty-2 branch):
d52abc9

Thank for your work.

  1. when you implement (de)serializing take into account that some paramentes may be null and yuo need to check it in code
  2. may I ask you to make your PR as a change to netty-2 branch and make them as isolated commit / work (your PR contains now 5 commints) to simplify my work ?
  3. we need to implement 2 unit tests for checking of XML serializing. Please finish this work.
@vetss

This comment has been minimized.

Collaborator

vetss commented Jun 10, 2016

Missed part is:

  • adding of unit tests for serializing
    • for FCIBCCCAMELsequence1SMSImpl
    • FurnishChargingInformationSMSRequestImpl

@vetss vetss closed this in bd44f0b Feb 6, 2017

@deruelle deruelle removed the Peer Review label Feb 6, 2017

@vetss

This comment has been minimized.

Collaborator

vetss commented Feb 6, 2017

Hello @agafox

sorry for delayed response. I have committed your update and marked an operation as it has a support for XML serializing.

Final Fixing by:
bd44f0b
6d92e4b

SergeyLee added a commit to SergeyLee/jss7 that referenced this issue Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment