Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add String digits support for GenericDigits #58
I have checked your update, thanks for it.
(Althow the method notations is different - AbstractNumber keeps data in String form, GenericDigits keeps data in the byte form). Also GenericDigits is marked as for a national use, may be that is why we keep data in a byte array form.
Which digits do you carry in your sidei GenericDigits ? Are they only '0' - '9' digits or it may be *, @, a, b, c, something other characters ?
AbstractNumber current implementation uses encoding as a hexadecimal digits (0-9, a-f)
I am thinking, does ISUP use 10-15 codes at all (may be we need to code only 0-9 digits) ?
ok, I have found your comment for CAP primitives.
Here is an extract from CAP spec:
Please confirm that you need this functionality only for usage for CAP stack.
CAP: org.mobicents.protocols.ss7.isup.impl.message.parameter.Digits :
Is it what you need ?
You guess right Sergey :-)
My intension was to make the implementation more generic and handle all Hex digits including special telco signes #, *, F depending on encoding scheme.
Any way I had some doubths if TBCD shall be used or plain BCD with neeble reverse order. Additionally I extended GenericDigits class according to: "Note that when CorrelationID is transported in Generic Digits, then the digits shall always be BCD encoded." and current CAP ETC operation API.
The only think I am confused about is special digits representation as there are differencies with coding special chars in (http://www.etsi.org/deliver/etsi_etr/001_099/060/02_60/etr_060e02p.pdf page 15):
and comment form specification you mentioned:
Additionally the spcs does not mention TBCD encoding but just BCD - I just added nibbles reverse order based on examplary traces I had.
What do you think will be the best final implementation? Shall I extend ISUP related GenericDigits as CAPGenericDigits impl in CAP stack (changing also CAPParameterFactory API)? Then what encoding shall be used - I opt for TBCD but CAP spec compliant abcd#*f?
Indeed I need the follwoing API: