New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IstCommandRequest, IstCommandResponse, SetReportingStateRequest and SetReportingStateResponse do not extend CallHandlingMessage #75

Closed
SummaNetworks opened this Issue May 5, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@SummaNetworks
Collaborator

SummaNetworks commented May 5, 2016

In MAP Protocol, callhandling service implementation, classes
org.mobicents.protocols.ss7.map.api.service.callhandling.IstCommandResponse,
org.mobicents.protocols.ss7.map.api.service.callhandling.IstCommandRequest,
org.mobicents.protocols.ss7.map.api.service.callhandling.SetReportingStateRequest,
org.mobicents.protocols.ss7.map.api.service.callhandling.SetReportingStateResponse extend Serializable instead of CallHandlingMessage.

@SummaNetworks SummaNetworks changed the title from SetReportingStateRequest and SetReportingStateResponse do not implement CallHandlingMessage to IstCommandRequest, IstCommandResponse, SetReportingStateRequest and SetReportingStateResponse do not implement CallHandlingMessage May 5, 2016

@SummaNetworks SummaNetworks changed the title from IstCommandRequest, IstCommandResponse, SetReportingStateRequest and SetReportingStateResponse do not implement CallHandlingMessage to IstCommandRequest, IstCommandResponse, SetReportingStateRequest and SetReportingStateResponse do not extend CallHandlingMessage May 5, 2016

@deruelle deruelle added the enhancement label May 5, 2016

@deruelle deruelle added this to the 3.0.0 milestone May 5, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented May 11, 2016

Hello, thanks for a provided PR - #76. I have left some comments there.

Please fix mentioned by me remarks and then provide a new pull request for ONE operation, I will check and commit and only then we will be able to go forward.

@vetss vetss modified the milestones: 3.1.0, 3.0.0 May 13, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented May 20, 2016

I have committed data from #76 pull request and closed it.

@deruelle

This comment has been minimized.

Member

deruelle commented May 23, 2016

@SummaNetworks Thanks. Acknowledged at https://telestax.com/acknowledgements/
@vetss shall this issue be closed ?

@vetss vetss modified the milestones: 3.0.0, 3.1.0 May 23, 2016

@vetss

This comment has been minimized.

Collaborator

vetss commented May 26, 2016

I am closing the issue, it looks like all is done. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment