New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typo in REstricted -> Restricted #147

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@raidan2
Contributor

raidan2 commented Jul 27, 2016

What I really want is to understand: is it worth it to finally fix all such typos in method names like

    public void setAddressRepresentationREstrictedIndicator(int addressRepresentationREstrictedIndicator) {
        this.addressRepresentationRestrictedIndicator = addressRepresentationREstrictedIndicator;
    }

i.e. setAddressRepresentationREstrictedIndicator -> setAddressRepresentationRestrictedIndicator?

I could do it.
I believe it should be done since we have version 8.

@deruelle deruelle added this to the 7.1.0 milestone Jul 27, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Jul 27, 2016

Thanks @raidan2. Can you accept the Contributor License agreement at http://www.telestax.com/open-source/#Contribute so we can accept your contributions ?

@raidan2

This comment has been minimized.

Contributor

raidan2 commented Jul 27, 2016

@deruelle, done.

@vetss

This comment has been minimized.

Collaborator

vetss commented Aug 2, 2016

I have added your commit. Thanks for your work.

@vetss vetss closed this Aug 2, 2016

@deruelle deruelle removed the Peer Review label Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment